Fixes for coding violations

[u/mrichter/AliRoot.git] / MUON / AliMUONLocalTriggerBoard.cxx

diff --git a/MUON/AliMUONLocalTriggerBoard.cxx b/MUON/AliMUONLocalTriggerBoard.cxx
index 9dc5583acde13d68ebc23b0fe574eb6019d6420e..423789bac5e70840f1ea751290c7698856df426b 100644 (file)
--- a/MUON/AliMUONLocalTriggerBoard.cxx
+++ b/MUON/AliMUONLocalTriggerBoard.cxx
@@ -115,6 +115,88 @@ AliMUONLocalTriggerBoard::AliMUONLocalTriggerBoard(AliMpLocalBoard* mpLocalBoard
    for (Int_t i=0; i<2; i++) fLutLpt[i] = fLutHpt[i] = 0;
 }
 
+//___________________________________________
+AliMUONLocalTriggerBoard::AliMUONLocalTriggerBoard(const AliMUONLocalTriggerBoard& right) :
+  AliMUONTriggerBoard(right),
+  fMpLocalBoard(right.fMpLocalBoard),
+  fStripX11(right.fStripX11),
+  fStripY11(right.fStripY11),
+  fDev(right.fDev),
+  fTrigY(right.fTrigY),
+  fOutput(right.fOutput),
+  fLUT(right.fLUT),
+  fCoinc44(right.fCoinc44)
+{
+  //
+  /// Copy constructor
+  //
+  for (Int_t i=0; i<2; i++) {
+    for (Int_t j=0; j<4; j++) {
+      fXY[i][j]  = right.fXY[i][j];
+      fXYU[i][j] = right.fXYU[i][j];
+      fXYD[i][j] = right.fXYD[i][j];
+
+      fMask[i][j] = right.fMask[i][j];
+    }
+  }
+
+  for (Int_t i=0; i<2; i++) {
+    fLutLpt[i] = right.fLutLpt[i];
+    fLutHpt[i] = right.fLutHpt[i];
+  }
+
+  for (Int_t i=0; i<5; i++) {
+    fMinDevStrip[i] = right.fMinDevStrip[i];
+    fMinDev[i] = right.fMinDev[i];
+    fCoordY[i] = right.fCoordY[i];
+  }
+}
+
+//___________________________________________
+AliMUONLocalTriggerBoard& AliMUONLocalTriggerBoard::operator=(const AliMUONLocalTriggerBoard& right)
+{
+/// Assigment operator;
+/// equal operator
+
+  if (this == &right)
+    return *this;
+
+  // base class assignement
+  AliMUONTriggerBoard::operator=(right);
+
+  fMpLocalBoard = right.fMpLocalBoard;
+  fStripX11 = right.fStripX11;
+  fStripY11 = right.fStripY11;
+  fDev      = right.fDev;
+  fTrigY    = right.fTrigY;
+  fOutput   = right.fOutput;
+  fLUT      = right.fLUT;
+  fCoinc44  = right.fCoinc44;
+
+  for (Int_t i=0; i<2; i++) {
+    for (Int_t j=0; j<4; j++) {
+      fXY[i][j]  = right.fXY[i][j];
+      fXYU[i][j] = right.fXYU[i][j];
+      fXYD[i][j] = right.fXYD[i][j];
+
+      fMask[i][j] = right.fMask[i][j];
+    }
+  }
+
+  for (Int_t i=0; i<2; i++) {
+    fLutLpt[i] = right.fLutLpt[i];
+    fLutHpt[i] = right.fLutHpt[i];
+  }
+
+  for (Int_t i=0; i<5; i++) {
+    fMinDevStrip[i] = right.fMinDevStrip[i];
+    fMinDev[i] = right.fMinDev[i];
+    fCoordY[i] = right.fCoordY[i];
+  }
+
+  return *this;  
+}
+
 //___________________________________________
 AliMUONLocalTriggerBoard::~AliMUONLocalTriggerBoard()
 {
@@ -142,20 +224,29 @@ void AliMUONLocalTriggerBoard::Reset()
       for (Int_t j=0; j<4; j++) 
          fXY[i][j] = fXYU[i][j] = fXYD[i][j] = 0;
 
-   fResponse = 0;
+   ResetResponse();
+}
 
-   for (Int_t i=0; i<5; i++) fMinDevStrip[i] = fMinDev[i] = fCoordY[i] = 0;
+//___________________________________________
+void AliMUONLocalTriggerBoard::ResetResponse()
+{
+/// reset board response
+//
+  fResponse = 0;
 
-   fOutput = 0;
+  for (Int_t i=0; i<5; i++) fMinDevStrip[i] = fMinDev[i] = fCoordY[i] = 0;
+
+  fOutput = 0;
    
-   fStripX11 = 0;
-   fStripY11 = 15;
-   fDev = 0;
-   fTrigY = 1;
+  fStripX11 = 0;
+  fStripY11 = 15;
+  fDev = 0;
+  fTrigY = 1;
 
-   for (Int_t i=0; i<2; i++) fLutLpt[i] = fLutHpt[i] = 0;
+  for (Int_t i=0; i<2; i++) fLutLpt[i] = fLutHpt[i] = 0;
 }
 
+
 //___________________________________________
 void AliMUONLocalTriggerBoard::Setbit(Int_t strip, Int_t cathode, Int_t chamber)
 {
@@ -204,7 +295,7 @@ void AliMUONLocalTriggerBoard::SetbitM(Int_t strip, Int_t cathode, Int_t chamber
 
 
 //___________________________________________
-void AliMUONLocalTriggerBoard::Pattern(Option_t *option) const
+void AliMUONLocalTriggerBoard::Pattern(const Option_t *option) const
 {
 /// print bit pattern
 ///
@@ -217,7 +308,7 @@ void AliMUONLocalTriggerBoard::Pattern(Option_t *option) const
 
 
 //___________________________________________
-void AliMUONLocalTriggerBoard::BP(Option_t *option) const
+void AliMUONLocalTriggerBoard::BP(const Option_t *option) const
 {
 /// Respect the old printout format
   
@@ -416,28 +507,6 @@ void AliMUONLocalTriggerBoard::BP(Option_t *option) const
    }
 }
 
-//___________________________________________
-void AliMUONLocalTriggerBoard::Module(char *mod)
-{
-/// get module from name
-///
-   const Int_t kMaxfields = 2; char **fields = new char*[kMaxfields];
-
-   char s[100]; strcpy(s, GetName());
-
-   Int_t numlines = 0;
-
-   for (char *token = strtok(s, "B");
-        token != NULL;
-        token = strtok(NULL, " "))
-   {
-      fields[numlines] = new char[strlen(token)+1];
-      strcpy(fields[numlines++],token);
-   }
- 
-   strcpy(mod,fields[0]);
-}
-
 //___________________________________________
 void AliMUONLocalTriggerBoard::TrigX(Int_t ch1q[16], Int_t ch2q[16], Int_t ch3q[32], Int_t ch4q[32])
 {
@@ -883,6 +952,8 @@ void AliMUONLocalTriggerBoard::TrigY(Int_t y1[16], Int_t y2[16], Int_t y3[16], I
       tmpy4dto16[2*i+1] = (y4d[i]&GetSwitch(0)) | (y4d[2*i+1]&!GetSwitch(0));
    }
   
+   for (i=0; i<16; i++) ch3[i] = ch4[i] = 0;
+
    if (GetSwitch(3)==0&&GetSwitch(4)==0){
       for (i=0; i<16; i++){
          ch3[i] = tmpy3to16[i];
@@ -1103,9 +1174,10 @@ Int_t AliMUONLocalTriggerBoard::GetI() const
 {
 /// old numbering
 ///
+
    const Int_t kMaxfields = 2; char **fields = new char*[kMaxfields];
 
-   char s[100]; strcpy(s, GetName());
+   char s[100]; strncpy(s, GetName(), 99);
 
    Int_t numlines = 0;
 
@@ -1139,6 +1211,8 @@ Int_t AliMUONLocalTriggerBoard::GetI() const
    Int_t ic = 0;
 
    for (Int_t i=0; i<234; i++) if (fgkCircuitId[i] == code) {ic = i; break;}
+   
+   delete [] fields;
 
    return ic;
 }
@@ -1151,7 +1225,7 @@ void AliMUONLocalTriggerBoard::Mask(Int_t index, UShort_t mask)
   if ( index >= 0 && index < 2*4 )
   {
     Int_t i = index/4;
-    Int_t j = index - i*4;
+    Int_t j = index%4;
     fMask[i][j]=mask;
   }
   else
@@ -1175,6 +1249,8 @@ void AliMUONLocalTriggerBoard::Scan(Option_t *option) const
 
    if (op.Contains("RESPF")) Resp("F"); 
 
+   if (op.Contains("RESPO")) Resp("O");
+
    if (op.Contains("ALL"))
    {
       Conf();
@@ -1225,6 +1301,13 @@ void AliMUONLocalTriggerBoard::Resp(Option_t *option) const
       for  (Int_t i=4; i>=0; i--) printf("%i",fCoordY[i]); 
       printf(" \n");
    }
+   if (op.Contains("O")){
+     printf("-- Output --\n");
+     printf("Coinc44 %i\n", fCoinc44);
+     printf("StripX11 %i  StripY11 %i  Dev %i  TrigY %i\n", fStripX11, fStripY11, fDev, fTrigY);
+     printf("LutLpt %i %i  LutHpt %i %i\n", fLutLpt[0], fLutLpt[1], fLutHpt[0], fLutHpt[1]);
+     printf("Response %i\n", fOutput);
+   }
 
 }
 
@@ -1233,6 +1316,12 @@ void AliMUONLocalTriggerBoard::Response()
 {
 /// algo
 ///
+  if ( IsNull() ) {
+    fMinDev[4] = 1;
+    for  (Int_t i=4; i>=0; i--) fCoordY[i] = 1;
+    return; // Do nothing if strip pattern is null
+  }
+
    Int_t xX1[16], xX2[16], xXX3[32], xXX4[32];
 
    TBits x1(16), x2(16), x3(16), x4(16);
@@ -1342,3 +1431,15 @@ Bool_t AliMUONLocalTriggerBoard::IsTrigX() const
 
   return output;
 }
+
+//___________________________________________
+Bool_t AliMUONLocalTriggerBoard::IsNull() const
+{
+  /// Check if board has fired strips in the first station
+  for (Int_t icath=0; icath<2; icath++){
+    for(Int_t ich=0; ich<2; ich++){
+      if ( fXY[icath][ich] ) return kFALSE;
+    }
+  }
+  return kTRUE;
+}