]> git.uio.no Git - u/mrichter/AliRoot.git/blobdiff - MUON/AliMUONPedestal.cxx
Fix bug in protection against division by 0.
[u/mrichter/AliRoot.git] / MUON / AliMUONPedestal.cxx
index bf9bf33bebbeeb8ca813912574b66b65ecc8a7db..e1f36440e58dbead65680edf57b44c779eb5f830 100644 (file)
 #include "AliMUONVStore.h"
 #include "AliMUON2DMap.h"
 #include "AliMUONCalibParamND.h"
-
+#include "AliMpConstants.h"
 #include <TString.h>
 #include <TTimeStamp.h>
 #include <TMath.h>
 #include <TTree.h>
 #include <TFile.h>
 #include <TH1F.h>
+#include <THashList.h>
 #include <Riostream.h>
 
 #include <sstream>
 /// \author Alberto Baldisseri, JL Charvet (05/05/2009)
 //-----------------------------------------------------------------------------
 
+using std::ostream;
+using std::ifstream;
+using std::endl;
+using std::cout;
+using std::ios;
 /// \cond CLASSIMP
 ClassImp(AliMUONPedestal)
 /// \endcond
@@ -49,23 +55,63 @@ ClassImp(AliMUONPedestal)
 //______________________________________________________________________________
 AliMUONPedestal::AliMUONPedestal()
 : TObject(),
-fN(0),
+//fN(0),
+fNCurrentEvents(0),
+fNEvthreshold(0),
+fSorting(0),
 fNEvents(0),
 fRunNumber(0),
 fNChannel(0),
 fNManu(0),
+fNManuConfig(0),
+fConfig(1),
+fStatusDA(0),
+fHistos(0),
 fErrorBuspatchTable(new AliMUON2DMap(kFALSE)),
 fManuBuspatchTable(new AliMUON2DMap(kFALSE)),
+fManuBPoutofconfigTable(new AliMUON2DMap(kFALSE)),
 fDate(new TTimeStamp()),
 fFilcout(0),
+fHistoFileName(),
 fPedestalStore(new AliMUON2DMap(kTRUE)),
-fIndex(-1)
+fIndex(-1),
+fPrefixDA(),
+fPrefixLDC(),
+fHistoFile(0),
+fTree(0)
 {
 /// Default constructor
-  sprintf(fHistoFileName," ");
-  sprintf(fprefixDA," "); 
 }
-//  AliMUONPedestal& operator=(const AliMUONPedestal& other); Copy ctor
+//______________________________________________________________________________
+AliMUONPedestal::AliMUONPedestal(TRootIOCtor* /*dummy*/)
+: TObject(),
+//fN(0),
+fNCurrentEvents(0),
+fNEvthreshold(0),
+fSorting(0),
+fNEvents(0),
+fRunNumber(0),
+fNChannel(0),
+fNManu(0),
+fNManuConfig(0),
+fConfig(1),
+fStatusDA(0),
+fHistos(0),
+fErrorBuspatchTable(0),
+fManuBuspatchTable(0),
+fManuBPoutofconfigTable(0),
+fDate(0),
+fFilcout(0),
+fHistoFileName(),
+fPedestalStore(0),
+fIndex(-1),
+fPrefixDA(),
+fPrefixLDC(),
+fHistoFile(0),
+fTree(0)
+{
+/// Root IO constructor
+}
 
 //______________________________________________________________________________
 AliMUONPedestal::~AliMUONPedestal()
@@ -74,25 +120,103 @@ AliMUONPedestal::~AliMUONPedestal()
   delete fErrorBuspatchTable;
   delete fManuBuspatchTable;
   delete fPedestalStore;
+  delete fManuBPoutofconfigTable;
 }
 
+//______________________________________________________________________________
+const char* 
+AliMUONPedestal::GetHistoFileName() const
+{
+  /// Return the name of file we use to store histograms
+  return fHistoFileName.Data();
+}
+
+//______________________________________________________________________________
+void AliMUONPedestal::LoadConfig(const char* dbfile)
+{
+  /// Load MUONTRK configuration from ascii file "dbfile" (in DetDB)
+
+  Int_t manuId;
+  Int_t busPatchId;
+
+  ifstream filein(dbfile,ios::in);
+  
+  while (!filein.eof())
+    { 
+      filein >> busPatchId >> manuId;
+
+      AliMUONVCalibParam* ped = 
+       static_cast<AliMUONVCalibParam*>(fPedestalStore ->FindObject(busPatchId, manuId));
+
+      if (!ped) {
+       fNManuConfig++;
+       fNChannel+=64;
+  ped = new AliMUONCalibParamND(2, AliMpConstants::ManuNofChannels(),busPatchId, manuId, -1.); // put default wise -1, not connected channel
+       fPedestalStore ->Add(ped);  
+
+        if ( ! fManuBuspatchTable->FindObject(busPatchId,manuId) )
+         {
+           // New (buspatch,manu)
+           AliMUONErrorCounter* manuCounter = new AliMUONErrorCounter(busPatchId,manuId);
+           fManuBuspatchTable->Add(manuCounter);
+         }
+      }
+    }
+} 
 //______________________________________________________________________________
 void AliMUONPedestal::MakePed(Int_t busPatchId, Int_t manuId, Int_t channelId, Int_t charge)
 {
+  static Int_t tree_charge=0;
+  static Int_t warn=0;
+  Int_t DDL= busPatchId/100+2560;
   /// Compute pedestals values
   AliMUONVCalibParam* ped = 
     static_cast<AliMUONVCalibParam*>(fPedestalStore ->FindObject(busPatchId, manuId));
 
-  if (!ped) {
-    fNManu++;
-    ped = new AliMUONCalibParamND(2, kNChannels,busPatchId, manuId, -1.); // put default wise -1, not connected channel
-    fPedestalStore ->Add(ped);  
-  }
+
+  if(!tree_charge && fHistos==2)
+    {
+      fTree = new TTree("tc","Charge tree");
+      fTree->Branch("bp",&busPatchId,"bp/I");
+      fTree->Branch("manu",&manuId,",manu/I");
+      fTree->Branch("channel",&channelId,",channel/I");
+      fTree->Branch("DDL",&DDL,",DDL/I");
+      fTree->Branch("charge",&charge,"charge/I");
+      //      fTree->Branch("Pedestal",&Pedestal,"Pedestal/D");
+      //      fTree->Branch("chargetrue",&chargeminusPed,"chargetrue/D");
+      //      fTree->Branch("evt",&evt,"evt/I");
+      tree_charge=1;
+    }
+
+
+  if (!ped)   
+    {
+      if(fConfig) 
+       {  // Fill out_of_config (buspatch,manu) table
+         if (!(static_cast<AliMUONErrorCounter*>(fManuBPoutofconfigTable->FindObject(busPatchId,manuId))))
+           fManuBPoutofconfigTable->Add(new AliMUONErrorCounter(busPatchId,manuId));
+         if(warn<10) cout << fPrefixLDC.Data() << " : !!! WARNING  : busPatchId = " << busPatchId << " manuId = " << manuId << " not in the Detector configuration " << endl;
+         else if(warn==10) cout << fPrefixLDC.Data() << " : !!! see .log file for an exhaustive list of (busPatchId, manuId) out of Detector configuration \n" << endl; 
+          warn++;
+          (*fFilcout) <<" !!! WARNING  : busPatchId = " << busPatchId << " manuId = " << manuId << " not in the Detector configuration " << endl; 
+       }
+      else {fNManu++;}
+      fNChannel+=64;
+      // put default wise -1, not connected channel
+      ped = new AliMUONCalibParamND(2, AliMpConstants::ManuNofChannels(),busPatchId, manuId, -1.); 
+      fPedestalStore ->Add(ped);  
+    }
 
   // Initialization for the first value
-  if (ped->ValueAsDouble(channelId, 0) == -1) ped->SetValueAsDouble(channelId, 0, 0.);
+  if (ped->ValueAsDouble(channelId, 0) == -1)  
+    { 
+      if(fConfig && channelId == 0){fNManu++;}
+      ped->SetValueAsDouble(channelId, 0, 0.);
+    }
   if (ped->ValueAsDouble(channelId, 1) == -1) ped->SetValueAsDouble(channelId, 1, 0.);
 
+  if(fHistos==2) fTree->Fill();  
+
   Double_t pedMean  = ped->ValueAsDouble(channelId, 0) + (Double_t) charge;
   Double_t pedSigma = ped->ValueAsDouble(channelId, 1) + (Double_t) charge*charge;
 
@@ -112,199 +236,310 @@ void AliMUONPedestal::MakePed(Int_t busPatchId, Int_t manuId, Int_t channelId, I
       manuCounter->Increment();
     }  
 }
-
 //______________________________________________________________________________
 void AliMUONPedestal::Finalize()
 {
+  /// final polishing of the store
+  
   Double_t pedMean;
   Double_t pedSigma;
+  Double_t pedSigmalimit=0.5;
   Int_t busPatchId;
   Int_t manuId;
   Int_t channelId;
+  Int_t status=0;
 
   // print in logfile
   if (fErrorBuspatchTable->GetSize())
-  {
-    cout<<"\n* Buspatches with less statistics (due to parity errors)"<<endl;
-    (*fFilcout)<<"\n* Buspatches with less statistics (due to parity errors)"<<endl;
-    TIter nextParityError(fErrorBuspatchTable->CreateIterator());
-    AliMUONErrorCounter* parityerror;
-    while((parityerror = static_cast<AliMUONErrorCounter*>(nextParityError())))
     {
-      cout<<"  bp "<<parityerror->BusPatch()<<": events used = "<<fNEvents-parityerror->Events()<<endl;
-      (*fFilcout)<<"  bp "<<parityerror->BusPatch()<<": events used = "<<fNEvents-parityerror->Events()<<endl;
+      cout<< "\n" << fPrefixLDC.Data() << " : See list of Buspatches with lower statistics (due to parity errors) in .log or .ped file "<<endl;
+      (*fFilcout)<<"\nWarning: Buspatches with less statistics (due to parity errors)"<<endl;
+      TIter nextParityError(fErrorBuspatchTable->CreateIterator());
+      AliMUONErrorCounter* parityerror;
+      while((parityerror = static_cast<AliMUONErrorCounter*>(nextParityError())))
+       {
+         //      cout<<"  bp "<<parityerror->BusPatch()<<": used events = "<<fNEvents-parityerror->Events()<<endl;
+         (*fFilcout)<<"  bp "<<parityerror->BusPatch()<<": used events = "<<fNEvents-parityerror->Events()<<endl;
+       }
     }
-  }
-
-// iterator over pedestal
+  
+  Int_t nADC4090=0;
+  Int_t nADCmax=0;
+  // iterator over pedestal
   TIter next(fPedestalStore ->CreateIterator());
   AliMUONVCalibParam* ped;
 
   while ( ( ped = dynamic_cast<AliMUONVCalibParam*>(next() ) ) )
-  {
-    busPatchId              = ped->ID0();
-    manuId                  = ped->ID1();
-    if(manuId==0)
-      {
-       cout << " !!! BIG WARNING: ManuId = " << manuId << " !!! in  BP = " << busPatchId << endl;
-       (*fFilcout) << " !!! BIG WARNING: ManuId = " << manuId << " !!! in  BP = " << busPatchId << endl;
-      }
-    Int_t eventCounter;
-    // Correct the number of events for buspatch with errors
-    AliMUONErrorCounter* errorCounter;
-    if ((errorCounter = (AliMUONErrorCounter*)fErrorBuspatchTable->FindObject(busPatchId)))
-    {
-      eventCounter = fNEvents - errorCounter->Events();
-    }
-    else
     {
-      eventCounter = fNEvents;
-    }
+      busPatchId              = ped->ID0();
+      manuId                  = ped->ID1();
+      if(manuId==0)
+       {
+         cout << fPrefixLDC.Data() << " : Warning: ManuId = " << manuId << " !!! in  BP = " << busPatchId << endl;
+         (*fFilcout) << "Warning: ManuId = " << manuId << " !!! in  BP = " << busPatchId << endl;
+       }
+      Int_t eventCounter;
+      // Correct the number of events for buspatch with errors
+      AliMUONErrorCounter* errorCounter;
+      if ((errorCounter = (AliMUONErrorCounter*)fErrorBuspatchTable->FindObject(busPatchId)))
+       {
+         eventCounter = fNEvents - errorCounter->Events();
+       }
+      else
+       {
+         eventCounter = fNEvents;
+       }
+      Int_t occupancy=0; // channel missing in raw data or read but rejected (case of parity error)
+      // value of (buspatch, manu) occupancy
+      AliMUONErrorCounter* manuCounter;
+      manuCounter = static_cast<AliMUONErrorCounter*>(fManuBuspatchTable->FindObject(busPatchId,manuId));
+      if(eventCounter>0)occupancy = manuCounter->Events()/64/eventCounter;
+      if(occupancy>1)
+       {
+         cout << fPrefixLDC.Data() << " : Warning: ManuId = " << manuId << " !!! in  BP = " << busPatchId << " occupancy (>1) = " << occupancy << endl;
+         (*fFilcout) << "Warning: ManuId = " << manuId << " !!! in  BP = " << busPatchId << " occupancy (>1) = " << occupancy <<endl;
+       }
+
+      for (channelId = 0; channelId < ped->Size() ; ++channelId) 
+       {
+         pedMean  = ped->ValueAsDouble(channelId, 0);
 
-    Int_t occupancy;
-    // value of (buspatch, manu) occupancy
-    AliMUONErrorCounter* manuCounter;
-    manuCounter = static_cast<AliMUONErrorCounter*>(fManuBuspatchTable->FindObject(busPatchId,manuId));
-    occupancy = manuCounter->Events()/64/eventCounter;
-    if(occupancy>1)
-    {
-      cout << " !!! BIG WARNING: ManuId = " << manuId << " !!! in  BP = " << busPatchId << " occupancy (>1) = " << occupancy << endl;
-      (*fFilcout) << " !!! BIG WARNING: ManuId = " << manuId << " !!! in  BP = " << busPatchId << " occupancy (>1) = " << occupancy <<endl;
+         if (pedMean >= 0) // connected channels
+           {
+             ped->SetValueAsDouble(channelId, 0, pedMean/(Double_t)eventCounter);
+             pedMean  = ped->ValueAsDouble(channelId, 0);
+             pedSigma = ped->ValueAsDouble(channelId, 1);
+             ped->SetValueAsDouble(channelId, 1, TMath::Sqrt(TMath::Abs(pedSigma/(Double_t)eventCounter - pedMean*pedMean)));
+
+             if(eventCounter < fNEvthreshold )
+               { nADCmax++; ped->SetValueAsDouble(channelId, 0, ADCMax());
+                 ped->SetValueAsDouble(channelId, 1, ADCMax());}
+             if( ped->ValueAsDouble(channelId, 1) < pedSigmalimit )
+               { nADC4090++; ped->SetValueAsDouble(channelId, 0, ADCMax()-5);
+                 ped->SetValueAsDouble(channelId, 1, ADCMax()-5);}
+             if(manuId == 0 || occupancy>1)
+               { nADCmax++; ped->SetValueAsDouble(channelId, 0, ADCMax());
+                 ped->SetValueAsDouble(channelId, 1, ADCMax());
+                 if(occupancy>1 && channelId==0)ped->SetValueAsDouble(channelId, 0, ADCMax()+occupancy);}
+           }
+         else
+           { nADCmax++; ped->SetValueAsDouble(channelId, 0, ADCMax());
+             ped->SetValueAsDouble(channelId, 1, ADCMax());}
+       }
     }
 
-    for (channelId = 0; channelId < ped->Size() ; ++channelId) 
+  float frac1=0. , frac2=0. ;
+  float frac_badped = 0.25 ; // maximal acceptable ratio of bad pedestals
+  char* detail;
+  if(fNChannel)
     {
-      pedMean  = ped->ValueAsDouble(channelId, 0);
-
-      if (pedMean > 0) // connected channels
-      {
-         ped->SetValueAsDouble(channelId, 0, pedMean/(Double_t)eventCounter);
-         pedMean  = ped->ValueAsDouble(channelId, 0);
-         pedSigma = ped->ValueAsDouble(channelId, 1);
-         ped->SetValueAsDouble(channelId, 1, TMath::Sqrt(TMath::Abs(pedSigma/(Double_t)eventCounter - pedMean*pedMean)));
-         if(manuId == 0 || occupancy>1)
-         {
-             ped->SetValueAsDouble(channelId, 0, kADCMax);
-             ped->SetValueAsDouble(channelId, 1, kADCMax);
-         }
-      }
-      else
-      {
-         ped->SetValueAsDouble(channelId, 0, kADCMax);
-         ped->SetValueAsDouble(channelId, 1, kADCMax);
-      }
+      if(nADCmax>0)
+       { frac1 = float(nADCmax)/float(fNChannel); 
+         detail=Form("%s : Warning: Nb of Channels with bad Pedestal (Ped=4095) = %d over %d (%6.4f)",fPrefixLDC.Data(),nADCmax,fNChannel,frac1);
+         printf("%s\n",detail);
+         (*fFilcout) <<  detail << endl;}
+
+      if(nADC4090>0)
+       { frac2 = 1.*nADC4090/fNChannel; 
+         detail=Form("%s : Warning: Nb of Channels with PedSigma<0.5 (Ped=4090) = %d over %d (%6.4f)",fPrefixLDC.Data(),nADC4090,fNChannel,frac2);
+         printf("%s\n",detail);
+         (*fFilcout) <<  detail << endl; }
+
+      if (frac1+frac2 > frac_badped) { status=-1 ;
+       detail=Form("\n%s !!! ERROR : fraction of Channels with Pedestal>=4090 = %6.4f (> %5.3f)  (status= %d) \n",fPrefixLDC.Data(),frac1+frac2,frac_badped,status);
+       (*fFilcout) <<  detail << endl; printf("%s",detail) ;}
     }
-  }
+  else { status= -1;
+    detail=Form("\n%s !!! ERROR : Nb good channel = 0 (all pedestals are forced to 4095) !!! (status= %d)\n",fPrefixLDC.Data(),status); 
+    cout << detail; (*fFilcout) << detail ;}
+   
+  SetStatusDA(status);
 }
-
 //______________________________________________________________________________
 void AliMUONPedestal::MakeASCIIoutput(ostream& out) const
 {
 /// put pedestal store in the output stream
 
   out<<"//===========================================================================" << endl;
-  out<<"//                       Pedestal file calculated by MUONTRKda"<<endl;
+  out<<"//                 Pedestal file calculated by "<< fPrefixDA.Data() << endl;
   out<<"//===========================================================================" << endl;
-  out<<"//       * Run           : " << fRunNumber << endl; 
-  out<<"//       * Date          : " << fDate->AsString("l") <<endl;
-  out<<"//       * Statictics    : " << fNEvents << endl;
-  out<<"//       * # of MANUS    : " << fNManu << endl;
-  out<<"//       * # of channels : " << fNChannel << endl;
+  out<<"//     * Run           : " << fRunNumber << endl; 
+  out<<"//     * Date          : " << fDate->AsString("l") <<endl;
+  out<<"//     * Statictics    : " << fNEvents << endl;
+  if(fConfig)
+    out<<"//     * Nb of MANUS   : " << fNManuConfig << " read in the Det. config. " << endl;
+  out<<"//     * Nb of MANUS   : " << fNManu << " read in raw data " << endl;
+  out<<"//     * Nb of MANUS   : " << fNChannel/64 << " written in pedestal file " << endl;
+  out<<"//     * Nb of channels: " << fNChannel << endl;
+  out<<"//"<<endl;
+  out<<"//     * Below " << fNEvthreshold << " events=> Ped.&sig.=4095" << endl;
+  out<<"//     * PedSigma < 0.5 => Ped.&sig.=4090" << endl;
+
   if (fErrorBuspatchTable->GetSize())
-  {
-    out<<"//"<<endl;
-    out<<"//       * Buspatches with less statistics (due to parity errors)"<<endl;
-    TIter next(fErrorBuspatchTable->CreateIterator());
-    AliMUONErrorCounter* parityerror;
-    while((parityerror = static_cast<AliMUONErrorCounter*>(next())))
     {
-      out<<"//         bp "<<parityerror->BusPatch()<<" events used "<<fNEvents-parityerror->Events()<<endl;
+      out<<"//"<<endl;
+      out<<"//    * Buspatches with less statistics (due to parity errors)"<<endl;
+      TIter next(fErrorBuspatchTable->CreateIterator());
+      AliMUONErrorCounter* parityerror;
+      while((parityerror = static_cast<AliMUONErrorCounter*>(next())))
+       {
+         if(fNEvents-parityerror->Events()>fNEvthreshold)
+           { out<<"//      BusPatch = "<<parityerror->BusPatch()<<"\t Nevents used = "<<fNEvents-parityerror->Events()<<endl; }
+         else
+           { out<<"//      BusPatch = "<<parityerror->BusPatch()<<"\t Nevents used = "<<fNEvents-parityerror->Events()<< " (Ped.&sig.=4095)" << endl; }
+       }
+    }  
+  Int_t writitle=0;
+  Int_t occupancy=1;
+  if(occupancy)
+    {
+      TIter next(fPedestalStore ->CreateIterator());
+      AliMUONVCalibParam* ped;
+      while ( ( ped = dynamic_cast<AliMUONVCalibParam*>(next() ) ) )
+       {
+         Int_t busPatchId = ped->ID0();
+         Int_t manuId = ped->ID1();
+         Double_t pedMean  = ped->ValueAsDouble(0, 0); // check pedestal value for channelId=0
+
+         if(pedMean>ADCMax()) 
+           {
+             writitle++;
+             if(writitle==1){ 
+               out<<"//"<<endl;
+               out<<"//    * Puzzling (Buspatch,Manu) read in raw data ? (Ped.&sig.=4095)"<<endl;}
+             occupancy=TMath::Nint(pedMean-ADCMax());
+             ped->SetValueAsDouble(0, 0, ADCMax());
+             out<<"//      BusPatch = "<< busPatchId <<"\t ManuId =  "<< manuId << "\t occupancy = " << occupancy  << endl;
+           }
+
+         if (manuId==0 || (fConfig && static_cast<AliMUONErrorCounter*>(fManuBPoutofconfigTable->FindObject(busPatchId,manuId))))
+           {
+             writitle++;
+             if(writitle==1){ 
+               out<<"//"<<endl;
+               out<<"//    * Puzzling (Buspatch,Manu) read in raw data ? (Ped.&sig.=4095)"<<endl;}
+             out<<"//      BusPatch = "<< busPatchId <<"\t ManuId =  "<< manuId << "\t missing in the mapping" << endl;
+           }
+       }
     }
-  }  
   out<<"//"<<endl;
   out<<"//---------------------------------------------------------------------------" << endl;
   out<<"//---------------------------------------------------------------------------" << endl;
   out<<"//      BP     MANU     CH.      MEAN    SIGMA"<<endl;
   out<<"//---------------------------------------------------------------------------" << endl;
 
-  // iterator over pedestal
-  TIter next(fPedestalStore ->CreateIterator());
-  AliMUONVCalibParam* ped;
-  
-  while ( ( ped = dynamic_cast<AliMUONVCalibParam*>(next() ) ) )
-  {
-    Int_t busPatchId = ped->ID0();
-    Int_t manuId = ped->ID1();
-    
-    for ( Int_t channelId = 0; channelId < ped->Size(); ++channelId ) 
+  TIter next(fPedestalStore->CreateIterator());
+  AliMUONVCalibParam* ped;  
+
+  // Sorting 
+  if  (fSorting)
     {
-      Double_t pedMean  = ped->ValueAsDouble(channelId, 0);
-      Double_t pedSigma = ped->ValueAsDouble(channelId, 1);
-        
-      out << "\t" << busPatchId << "\t" << manuId <<"\t"<< channelId << "\t" << pedMean <<"\t"<< pedSigma << endl;        
+      printf("%s : ..... sorting pedestal values .....\n",fPrefixLDC.Data());
+      THashList pedtable(100,2);
+      while ( ( ped = dynamic_cast<AliMUONVCalibParam*>(next() ) ) )
+      {
+        pedtable.Add(ped);
+      }
+      pedtable.Sort();
+      //      iterator over sorted pedestal
+      TIter nextSorted(&pedtable);
+      while ( (ped = (AliMUONVCalibParam*)(nextSorted()) ) )
+      {
+        Int_t busPatchId = ped->ID0();
+        Int_t manuId = ped->ID1();
+        for ( Int_t channelId = 0; channelId < ped->Size(); ++channelId ) 
+        {
+          Double_t pedMean  = ped->ValueAsDouble(channelId, 0);
+          Double_t pedSigma = ped->ValueAsDouble(channelId, 1);
+          out << "\t" << busPatchId << "\t" << manuId <<"\t"<< channelId << "\t" << pedMean <<"\t"<< pedSigma << endl;
+        }
+      }
+    }
+  else
+    {
+      while ( ( ped = dynamic_cast<AliMUONVCalibParam*>(next() ) ) )
+       {
+         Int_t busPatchId = ped->ID0();
+         Int_t manuId = ped->ID1();
+         for ( Int_t channelId = 0; channelId < ped->Size(); ++channelId ) 
+           {
+             Double_t pedMean  = ped->ValueAsDouble(channelId, 0);
+             Double_t pedSigma = ped->ValueAsDouble(channelId, 1);
+             out << "\t" << busPatchId << "\t" << manuId <<"\t"<< channelId << "\t" << pedMean <<"\t"<< pedSigma << endl;
+           }
+       }
     }
-  }
 }
 
+//______________________________________________________________________________
+void AliMUONPedestal::CreateControlHistos()
+{
+// Create histo 
+  fHistoFileName=Form("%s.root",fPrefixDA.Data());
+  fHistoFile = new TFile(fHistoFileName,"RECREATE","MUON Tracking pedestals");
+}
 //______________________________________________________________________________
 void AliMUONPedestal::MakeControlHistos()
 {
-
+  /// Create control histograms
   if (fIndex>=0) return; // Pedestal run (fIndex=-1)
 
   Double_t pedMean;
   Double_t pedSigma;
+  Double_t evt;
   Int_t busPatchId;
   Int_t manuId;
   Int_t channelId;
+  Int_t DDL;
 
 // histo
-  TFile*  histoFile = 0;
+//  TFile*  histoFile = 0;
   TTree* tree = 0;
   TH1F* pedMeanHisto = 0;
   TH1F* pedSigmaHisto = 0;
     
-  sprintf(fHistoFileName,"%s.root",fprefixDA);
-  histoFile = new TFile(fHistoFileName,"RECREATE","MUON Tracking pedestals");
-
-  Char_t name[255];
-  Char_t title[255];
-  sprintf(name,"pedmean_allch");
-  sprintf(title,"Pedestal mean all channels");
-  Int_t nx = kADCMax+1;
+  //  fHistoFileName=Form("%s.root",fPrefixDA.Data());
+  //  histoFile = new TFile(fHistoFileName,"RECREATE","MUON Tracking pedestals");
+
+  Int_t nx = ADCMax()+1;
   Int_t xmin = 0;
-  Int_t xmax = kADCMax
-  pedMeanHisto = new TH1F(name,title,nx,xmin,xmax);
-  pedMeanHisto->SetDirectory(histoFile);
+  Int_t xmax = ADCMax()
+  pedMeanHisto = new TH1F("pedmean_allch","Pedestal mean all channels",nx,xmin,xmax);
+  pedMeanHisto->SetDirectory(fHistoFile);
 
-  sprintf(name,"pedsigma_allch");
-  sprintf(title,"Pedestal sigma all channels");
   nx = 201;
   xmin = 0;
   xmax = 200; 
-  pedSigmaHisto = new TH1F(name,title,nx,xmin,xmax);
-  pedSigmaHisto->SetDirectory(histoFile);
+  pedSigmaHisto = new TH1F("pedsigma_allch","Pedestal sigma all channels",nx,xmin,xmax);
+  pedSigmaHisto->SetDirectory(fHistoFile);
 
   tree = new TTree("t","Pedestal tree");
+  tree->Branch("DDL",&DDL,",DDL/I");
   tree->Branch("bp",&busPatchId,"bp/I");
   tree->Branch("manu",&manuId,",manu/I");
   tree->Branch("channel",&channelId,",channel/I");
   tree->Branch("pedMean",&pedMean,",pedMean/D");
   tree->Branch("pedSigma",&pedSigma,",pedSigma/D");
+  tree->Branch("nevt",&evt,",evt/D");
 
   // iterator over pedestal
   TIter next(fPedestalStore ->CreateIterator());
   AliMUONVCalibParam* ped;
+  AliMUONErrorCounter* manuCounter;
   
   while ( ( ped = dynamic_cast<AliMUONVCalibParam*>(next() ) ) )
   {
     busPatchId = ped->ID0();
     manuId = ped->ID1();
+    DDL= busPatchId/100+2560;
     
     for ( channelId = 0; channelId < ped->Size(); ++channelId ) 
     {
       pedMean  = ped->ValueAsDouble(channelId, 0);
       pedSigma = ped->ValueAsDouble(channelId, 1);
+      manuCounter = static_cast<AliMUONErrorCounter*>(fManuBuspatchTable->FindObject(busPatchId,manuId));
+      evt = manuCounter->Events()/64;
           
       pedMeanHisto->Fill(pedMean);
       pedSigmaHisto->Fill(pedSigma);
@@ -312,7 +547,7 @@ void AliMUONPedestal::MakeControlHistos()
     }
   }
     
-  histoFile->Write();  
-  histoFile->Close(); 
+  fHistoFile->Write();  
+  fHistoFile->Close(); 
 
 }