]> git.uio.no Git - u/mrichter/AliRoot.git/blobdiff - STEER/AliGRPPreprocessor.cxx
ITS cluster multiplicity and TPC standalone multiplicity in AODHeader
[u/mrichter/AliRoot.git] / STEER / AliGRPPreprocessor.cxx
index 5cb0da92125161113a7c78cb8c28a8e8aa8fc46a..d3841dc687274041abd57b4c0f65580ab999d40d 100644 (file)
 #include <TList.h>
 #include <TMap.h>
 #include <TObjString.h>
+#include <TObjArray.h>
 #include <TGraph.h>
+#include <TString.h>
+#include <TFile.h>
 
 #include <float.h>
 
 
 #include "AliTriggerConfiguration.h"
 #include "AliTriggerRunScalers.h"
+#include "AliTriggerInput.h"
 
 #include "AliCDBMetaData.h"
-#include "AliLog.h"
-
+#include "AliESDVertex.h"
+#include "AliLHCReader.h"
+#include "AliLHCData.h"
+#include "AliDCSArray.h"
+#include "AliDAQ.h"
+#include "AliLTUConfig.h"
+
+class AliLog;
 class AliDCSValue;
 class AliShuttleInterface;
 
@@ -57,6 +67,7 @@ class AliShuttleInterface;
 #include <AliCDBId.h>
 #include <AliTriggerConfiguration.h>
 #include <AliCTPTimeParams.h>
+#include <AliLHCClockPhase.h>
 
 const Double_t kFitFraction = -1.;                 // Fraction of DCS sensor fits required
 
@@ -64,16 +75,15 @@ ClassImp(AliGRPPreprocessor)
 
 //_______________________________________________________________
 
-  const Int_t AliGRPPreprocessor::fgknDAQLbPar = 8; // num parameters in the logbook for PHYSICS runs, when beamType from DAQ logbook == NULL
-  const Int_t AliGRPPreprocessor::fgknDAQLbParReduced = 7; // num parameters in the logbook for the other cases
-  const Int_t AliGRPPreprocessor::fgknDCSDP = 51;   // number of dcs dps
+  const Int_t AliGRPPreprocessor::fgknDAQLbPar = 6; // num parameters in the logbook used to fill the GRP object
+  const Int_t AliGRPPreprocessor::fgknDCSDP = 48;   // number of dcs dps
   const Int_t AliGRPPreprocessor::fgknDCSDPHallProbes = 40;   // number of dcs dps
+  const Int_t AliGRPPreprocessor::fgknLHCDP = 6;   // number of dcs dps from LHC data
+  const Int_t AliGRPPreprocessor::fgkDCSDPHallTopShift = 4;   // shift from the top to get tp the Hall Probes names in the list of DCS DPs
+  const Int_t AliGRPPreprocessor::fgkDCSDPNonWorking = 5; // number of non working DCS DPs
   const char* AliGRPPreprocessor::fgkDCSDataPoints[AliGRPPreprocessor::fgknDCSDP] = {
-                   "LHCState",              // missing in DCS
                    "L3Polarity",
                    "DipolePolarity",
-                   "LHCLuminosity",         // missing in DCS
-                   "BeamIntensity",         // missing in DCS
                    "L3Current",
                    "DipoleCurrent",
                   "L3_BSF17_H1",
@@ -119,7 +129,7 @@ ClassImp(AliGRPPreprocessor)
                    "CavernTemperature",
                    "CavernAtmosPressure",
                    "SurfaceAtmosPressure",
-                   "CavernAtmosPressure2",
+                   "CavernAtmosPressure2"
                  };
 
   const char* AliGRPPreprocessor::fgkDCSDataPointsHallProbes[AliGRPPreprocessor::fgknDCSDPHallProbes] = {
@@ -162,25 +172,21 @@ ClassImp(AliGRPPreprocessor)
                   "Dipole_Outside_H1",
                   "Dipole_Outside_H2",
                   "Dipole_Outside_H3",
-                  "Dipole_Outside_Temperature",
+                  "Dipole_Outside_Temperature"
                  };
                  
-  const Short_t kSensors = 48; // start index position of sensor in DCS DPs
+  const Short_t kSensors = 45; // start index position of sensor in DCS DPs
   const Short_t kNumSensors = 3; // Number of sensors in DCS DPs (CavernAtmosPressure, SurfaceAtmosPressure, CavernAtmosPressure2)
 
 
-  const char* AliGRPPreprocessor::fgkLHCState[20] = {
-                   "P", "PREPARE",
-                   "J", "PREINJECTION",
-                   "I", "INJECTION",
-                   "F", "FILLING",
-                   "A", "ADJUST",
-                   "U", "UNSTABLE BEAMS",
-                   "S", "STABLE BEAMS",
-                   "D", "BEAM DUMP",
-                   "R", "RECOVER",
-                   "C", "PRECYCLE"
-                 };
+  const char* AliGRPPreprocessor::fgkLHCDataPoints[AliGRPPreprocessor::fgknLHCDP] = {
+         "LHC_Beam_Energy",
+         "LHC_MachineMode",
+         "LHC_BeamMode",
+          "LHC_Beams_Particle_Type",
+         "BPTX_Phase_Shift_B1",
+         "BPTX_Phase_Shift_B2"
+  };
 
   const char* kppError[] = {
                    "",
@@ -190,13 +196,18 @@ ClassImp(AliGRPPreprocessor)
                    "(DCS data points ERROR)",
                    "(Trigger Configuration ERROR)",
                    "(DAQ logbook ERROR determining partition of the run)",
-                   "(CTP timing ERROR)"
+                   "(CTP timing ERROR)",
+                  "(SPD Mean Vertex ERROR)",
+                  "(DCS FXS Error for LHC Data)",
+                  "(LHC Data Error)",
+                  "(LHC Clock Phase Error (from LHC Data))",
+                  "(LTU Configuration Error)"
   };
 
 //_______________________________________________________________
 
 AliGRPPreprocessor::AliGRPPreprocessor(AliShuttleInterface* shuttle):
-       AliPreprocessor("GRP",shuttle),  fPressure(0), fmaxFloat(0), fminFloat(0),fmaxDouble(0), fminDouble(0), fmaxInt(0), fminInt(0), fmaxUInt(0), fminUInt(0),fdaqStartEndTimeOk(kTRUE)
+       AliPreprocessor("GRP",shuttle),  fPressure(0), fmaxFloat(0), fminFloat(0),fmaxDouble(0), fminDouble(0), fmaxInt(0), fminInt(0), fmaxUInt(0), fminUInt(0),fdaqStartEndTimeOk(kTRUE),ffailedDPs(new TObjArray(fgknDCSDP))
 {
        // constructor - shuttle must be instantiated!
 
@@ -215,6 +226,7 @@ AliGRPPreprocessor::AliGRPPreprocessor(AliShuttleInterface* shuttle):
        AddRunType("NOISE");
        AddRunType("PULSER");
         AddRunType("STANDALONE_PULSER");
+        AddRunType("STANDALONE_BC");
 
        fmaxFloat = FLT_MAX;
        fminFloat = -FLT_MAX;
@@ -234,6 +246,7 @@ AliGRPPreprocessor::AliGRPPreprocessor(AliShuttleInterface* shuttle):
        AliInfo(Form("Max allowed unsigned integer = %u",(Int_t)fmaxUInt));
        AliInfo(Form("Min allowed unsigned integer = %u",(Int_t)fminUInt));
 
+       ffailedDPs->SetOwner(kTRUE);
 }
 
 //_______________________________________________________________
@@ -243,6 +256,8 @@ AliGRPPreprocessor::~AliGRPPreprocessor()
        //destructor
        
        delete fPressure;
+       delete ffailedDPs;
+
 }
 
 //_______________________________________________________________
@@ -264,6 +279,12 @@ void AliGRPPreprocessor::Initialize(Int_t run, UInt_t startTime, UInt_t endTime)
        AliInfo(Form("Pressure Entries: %d",array->GetEntries()));
        
        fPressure = new AliDCSSensorArray(GetStartTimeDCSQuery(), GetEndTimeDCSQuery(), array);
+
+       for (Int_t iDP=0; iDP < fgknDCSDP; iDP++){
+               TObjString* dp = new TObjString(fgkDCSDataPoints[iDP]);
+               ffailedDPs->AddAt(dp,iDP);
+       }
+
 }
 
 //_______________________________________________________________
@@ -280,26 +301,32 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
        TString detector = (TString)GetRunParameter("detector");   
 
        AliGRPObject *grpobj = new AliGRPObject();  // object to store data
+       grpobj->SetBeamEnergyIsSqrtSHalfGeV(); // new format
 
        //=================//
        // DAQ logbook     //
        //=================//
+
+       Log("*************** Processing DAQ logbook");
+
        UInt_t error = 0;
        
        Int_t iDaqLB = ProcessDaqLB(grpobj);
        TString runType = (TString)GetRunType();
        TString beamType = (TString)GetRunParameter("beamType");
-       //if((runType == "PHYSICS" && iDaqLB == fgknDAQLbPar && beamType!="Cosmics") ||  (runType == "PHYSICS" && iDaqLB == fgknDAQLbParReduced && beamType=="Cosmics") || (runType != "PHYSICS" && iDaqLB == fgknDAQLbParReduced)) {
-       if((runType == "PHYSICS" && iDaqLB == fgknDAQLbPar && !beamType.IsNull()) ||  (runType == "PHYSICS" && iDaqLB == fgknDAQLbParReduced && beamType.IsNull()) || (runType != "PHYSICS" && iDaqLB == fgknDAQLbParReduced)) {
-               Log(Form("DAQ Logbook, successful!"));
+       if(iDaqLB == fgknDAQLbPar) {
+               Log(Form("DAQ Logbook, successful! Retrieved %d/%d entries",iDaqLB,fgknDAQLbPar));
        } else {
-               Log(Form("DAQ Logbook, could not get all expected entries!!!"));
+               Log(Form("DAQ Logbook, could not get all expected entries!!! Retrieved only %d/%d entries",iDaqLB,fgknDAQLbPar));
                error |= 1;
        }
 
        //=================//
        // DAQ FXS         //
        //=================//
+
+       Log("*************** Processing DAQ FXS");
+
        UInt_t iDaqFxs = ProcessDaqFxs();
        if( iDaqFxs == 0 ) {
                Log(Form("DAQ FXS, successful!"));
@@ -311,6 +338,9 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
        //=================//
        // DCS FXS         //
        //=================//
+
+       Log("*************** Processing DCS FXS");
+
        UInt_t iDcsFxs = ProcessDcsFxs(partition, detector);
        if( iDcsFxs == 0 ) {
                Log(Form("DCS FXS, successful!"));
@@ -325,12 +355,28 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
        //=================//
        // DCS data points //
        //=================//
+
+       Log("*************** Processing DCS DPs");
+
        Log(Form("Starting DCS Query at %d and finishing at %d",GetStartTimeDCSQuery(),GetEndTimeDCSQuery()));
        Int_t entries = ProcessDcsDPs( valueMap, grpobj );
-       Log(Form("entries found = %d (should be %d)",entries, fgknDCSDP-4));
+       Log(Form("entries found = %d (should be %d)",entries, fgknDCSDP-fgkDCSDPNonWorking));
        if (fdaqStartEndTimeOk){
-               if( entries < fgknDCSDP-4 ) { // FIXME (!= ) LHState, LHCLuminosity, BeamIntensity, LH3_BSF4_H3 are not working yet...  
-                       Log(Form("Problem with the DCS data points!!! Only %d/%d entries found",entries,fgknDCSDP-4));
+               if( entries < fgknDCSDP - fgkDCSDPNonWorking ) { // L3_BSF4_H3, L3_BSF17_H1, L3_BSF17_H2, L3_BSF17_H3, L3_BSF17_Temperature are not working yet...  
+                       Log(Form("Possible problem with the DCS data points!!! Only %d/%d entries found - Please read further for more details",entries,fgknDCSDP-fgkDCSDPNonWorking));
+                       Log(Form("The DPs giving problems were:"));
+                       for (Int_t iDP = 0; iDP < fgknDCSDP; iDP++){
+                               TObjString *dpString = (TObjString*)ffailedDPs->At(iDP);
+                               if (dpString){
+                                       TString name = dpString->String();
+                                       if (name != "L3_BSF4_H3" && name != "L3_BSF17_H1" && name != "L3_BSF17_H2" && name != "L3_BSF17_H3" && name != "L3_BSF17_Temperature" ){
+                                               Log(Form("******** %s ******** not present, but foreseen --> causing an ERROR",name.Data()));
+                                       }
+                                       else {
+                                               Log(Form(" %s is not present, but was not generating any error since it is not ready in DCS - check the other DPs in this list!",name.Data()));
+                                       }
+                               }
+                       }
                        error |= 8;
                }
                else  Log(Form("DCS data points, successful!"));
@@ -341,6 +387,8 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
        // Trigger Configuration //
        //=======================//
 
+       Log("*************** Processing Trigger Configuration");
+
        const char * triggerConf = GetTriggerConfiguration();
 
        if (partition.IsNull() && !detector.IsNull()){ // standalone partition
@@ -408,6 +456,7 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
        // Trigger Timing Parameters //
         //===========================//
 
+       Log("*************** Processing Trigger Time Params");
        
        const char * triggerCTPtiming = GetCTPTimeParams();
 
@@ -472,6 +521,141 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
                Log(Form("Incorrect field in DAQ logbook for partition = %s and detector = %s, going into error without trigger timing parameters...",partition.Data(),detector.Data()));
                error |= 32;
        }
+
+        //===========================//
+       // LTU Configuration         //
+        //===========================//
+
+       Log("*************** Processing LTU Configuration");
+       
+       if (partition.IsNull() && !detector.IsNull()){ // standalone partition
+               Log("STANDALONE partition for current run, using LTU configuration dummy value");
+               AliCDBEntry *cdbEntry = GetFromOCDB("CTP","DummyLTUConfig");
+               if (!cdbEntry) {
+                       Log(Form("No dummy LTU Config entry found, going into error..."));
+                       error |= 2048;
+               }
+               else{
+                       TObjArray *ltuConfig = (TObjArray*)cdbEntry->GetObject();
+                       if (!ltuConfig){
+                               Log(Form("dummy LTU Config not found in OCDB entry, going into error..."));
+                               error |= 2048;
+                       }
+                       else {
+                               AliCDBMetaData metadata;
+                               metadata.SetResponsible("Roman Lietava");
+                               metadata.SetComment("LTU Config from dummy entry in OCDB");
+                               if (!Store("CTP","LTUConfig", ltuConfig, &metadata, 0, 0)) {
+                                       Log("Unable to store the dummy LTU Config object to OCDB!");
+                                       error |= 2048;
+                               }
+                       }
+               }
+       }
+
+       else if (!partition.IsNull() && detector.IsNull()){ // global partition
+       
+               Log("GLOBAL partition for current run, getting LTU Config from DAQ Logbook (logbook_detectors table)");
+               UInt_t  detectorMask = (UInt_t)(((TString)GetRunParameter("detectorMask")).Atoi());
+               Printf ("detectormask = %d",detectorMask);
+               TObjArray * ltuarray = new TObjArray();
+               ltuarray->SetOwner(1);
+               Bool_t isLTUok = kTRUE;
+               for(Int_t i = 0; i<AliDAQ::kNDetectors-2; i++){
+                       if ((detectorMask >> i) & 0x1) {
+                               TString det = AliDAQ::OfflineModuleName(i);
+                               TString detCTPName = AliTriggerInput::fgkCTPDetectorName[i];
+                               if (detCTPName == "CTP") {
+                                       detCTPName="TRG"; // converting according to what is found in DAQ logbook_detectors                                     
+                                       Printf("Processing CTP (CTP Detector name %s) --> SKIPPING, CTP does not have any LTU!!!!!!",detCTPName.Data());
+                                       continue;
+                               }                               
+                               Printf("Processing detector %s (CTP Detector name %s)",det.Data(),detCTPName.Data());
+                               TString* ltu = GetLTUConfig(detCTPName.Data());
+                               if (!ltu){
+                                       Log(Form("No LTU Configuration from DAQ logbook for detector %s (BUT it was expected)! The corresponding CDB entry will not be filled!",detCTPName.Data()));
+                                       error |= 2048;
+                                       isLTUok = kFALSE;
+                                       break;
+                               }
+                               else{
+                                       Float_t ltuFineDelay1 = ltu[0].Atof();
+                                       Float_t ltuFineDelay2 = ltu[1].Atof();
+                                       Float_t ltuBCDelayAdd = ltu[2].Atof();
+                                       const char* name = AliDAQ::DetectorName(i);
+                                       AliLTUConfig* ltuConfig = new AliLTUConfig((UChar_t)AliDAQ::DetectorID(name),ltuFineDelay1,ltuFineDelay2,ltuBCDelayAdd);
+                                       ltuarray->AddAtAndExpand(ltuConfig,i);
+                               }                               
+                       }
+               }
+               if (isLTUok){
+                       AliCDBMetaData metadata;
+                       metadata.SetBeamPeriod(0);
+                       metadata.SetResponsible("Roman Lietava");
+                       metadata.SetComment("LTU Configuration for current run");
+                       if (!Store("CTP","LTUConfig", ltuarray, &metadata, 0, 0)) {
+                               Log("Unable to store the LTU Config object to OCDB!");
+                               error |= 2048;
+                       }               
+               }
+               delete ltuarray;
+       }
+
+       else {
+               Log(Form("Incorrect field in DAQ logbook for partition = %s and detector = %s, going into error without trigger timing parameters...",partition.Data(),detector.Data()));
+               error |= 32;
+       }
+
+
+       //=================//
+       // LHC Data        //
+       //=================//
+
+       if (runType == "PHYSICS"){  // processing the LHC file only in PHYSICS runs
+               Log("*************** Processing LHC Data");
+
+               UInt_t iLHCData = ProcessLHCData(grpobj);
+               
+               if( iLHCData == 0 ) {
+                       Log(Form("LHC Data from DCS FXS, successful!"));
+               } else  if (iLHCData == 1) {
+                       Log(Form("LHC Data, problems with DCS FXS!"));
+                       error |= 256;
+               } else  if (iLHCData == 2) {
+                       Log(Form("LHC Data, problems with DAQ_time_start/DAQ_time_end!"));
+                       error |= 512;
+               } else if (iLHCData ==3){
+                       Log(Form("Problems in storing LHC Phase - going into Error"));
+                       error |= 1024;
+               } else if (iLHCData ==4){
+                       Log(Form("Problems with LHC Phase - going into Error"));
+                       error |= 1024;
+               } else{
+                       Log(Form("LHC Data problems"));
+                       error |= 512;
+               }
+       
+       }
+
+       //==================//
+       // SPD Mean Vertex  //
+       //==================//
+
+       Log("*************** Processing SPD Mean Vertex");
+
+       if (runType == "PHYSICS"){
+               UInt_t iSPDMeanVertex = ProcessSPDMeanVertex();
+               if( iSPDMeanVertex == 1 ) {
+                       Log(Form("SPD Mean Vertex, successful!"));
+               } else {
+                       Log(Form("SPD Mean Vertex failed!!!"));
+                       error |= 128; 
+               }
+       }
+       else {
+               Log("SPD Mean Vertex not processed since runType != PHYSICS");
+       }
+
        // storing AliGRPObject in OCDB
 
        AliCDBMetaData md;
@@ -481,24 +665,416 @@ UInt_t AliGRPPreprocessor::Process(TMap* valueMap)
        Bool_t result = kTRUE;
        result = Store("GRP", "Data", grpobj, &md); 
        delete grpobj;
-       
+
        if (result && !error ) {
                Log("GRP Preprocessor Success");
                return 0;
        } else {
-               Log( Form("GRP Preprocessor FAILS!!! %s%s%s%s%s%s%s",
+               Log( Form("GRP Preprocessor FAILS!!! %s%s%s%s%s%s%s%s%s%s%s%s",
                          kppError[(error&1)?1:0],
                          kppError[(error&2)?2:0],
                          kppError[(error&4)?3:0],
                          kppError[(error&8)?4:0],
                          kppError[(error&16)?5:0],
                          kppError[(error&32)?6:0],
-                         kppError[(error&64)?7:0]
+                         kppError[(error&64)?7:0],
+                         kppError[(error&128)?8:0],
+                         kppError[(error&256)?9:0],
+                         kppError[(error&512)?10:0],
+                         kppError[(error&1024)?11:0],
+                         kppError[(error&2048)?12:0]
                          ));
                return error;
        }
+
+
 }
 
+//_______________________________________________________________
+
+UInt_t AliGRPPreprocessor::ProcessLHCData(AliGRPObject *grpobj)
+{
+       //
+       //Getting the LHC Data from DCS FXS
+       //
+
+       TString timeStartString = (TString)GetRunParameter("DAQ_time_start");
+       TString timeEndString = (TString)GetRunParameter("DAQ_time_end");
+       if (timeStartString.IsNull() || timeEndString.IsNull()){
+               if (timeStartString.IsNull()){ 
+                       AliError("DAQ_time_start not set in logbook! Setting statistical values for current DP to invalid");
+               }
+               else if (timeEndString.IsNull()){
+                       AliError("DAQ_time_end not set in logbook! Setting statistical values for current DP to invalid");
+               }
+               return 2;
+       }  
+
+       Double_t timeStart = timeStartString.Atof();
+       Double_t timeEnd = timeEndString.Atof();
+
+       TString fileName = GetFile(kDCS, "LHCData","");
+       if (fileName.Length()>0){
+               AliInfo("Got The LHC Data file");
+               AliLHCReader lhcReader;
+
+               // Processing data to be put in AliGRPObject
+
+               // Energy
+               Log("*************Energy ");
+               TObjArray* energyArray = lhcReader.ReadSingleLHCDP(fileName.Data(),fgkLHCDataPoints[0]);
+               if (energyArray){                       
+                       Float_t energy = ProcessEnergy(energyArray,timeStart);
+                       if (energy != -1.) {
+                               grpobj->SetBeamEnergy(energy);
+                               grpobj->SetBeamEnergyIsSqrtSHalfGeV(kTRUE);
+                       }
+                       delete energyArray;
+               }
+               else {
+                       AliError("Energy not found in LHC Data file!!!");
+               }       
+
+               Double_t timeBeamModeEnd = timeEnd;        // max validity for Beam Mode 
+               Double_t timeMachineModeEnd = timeEnd;     // max validity for Machine Mode
+               Double_t timeBeamEnd = timeEnd;            // max validity for Beam Type
+               Double_t timeBeamModeStart = -1;    // min validity for Beam Mode
+               Double_t timeMachineModeStart = -1; // min validity for Machine Mode
+               Double_t timeBeamStart = -1;        // min validity for Beam Type
+               Int_t indexBeamMode = -1;                  // index of measurement used to set Beam Mode
+               Int_t indexMachineMode = -1;               // index of measurement used to set Beam Mode
+               Int_t indexBeam = -1;                      // index of measurement used to set Beam Mode
+               Bool_t foundBeamModeStart = kFALSE;        // flag to be set in case an entry for the Beam Mode is found before (or at) SOR
+               Bool_t foundMachineModeStart = kFALSE;     // flag to be set in case an entry for the Beam Mode is found before (or at) SOR
+               Bool_t foundBeamStart = kFALSE;            // flag to be set in case an entry for the Beam Mode is found before (or at) SOR
+               Bool_t flagBeamMode = kFALSE;  //flag set true if a changed occurred in BeamMode
+               Bool_t flagMachineMode = kFALSE;  //flag set true if a changed occurred in MachineMode
+               Bool_t flagBeam = kFALSE;  //flag set true if a changed occurred in BeamType
+               
+               // BeamMode
+               Log("*************BeamMode (LHCState) ");
+               TObjArray* beamModeArray = lhcReader.ReadSingleLHCDP(fileName.Data(),fgkLHCDataPoints[2]);
+               Int_t nBeamMode = -1;
+               if (beamModeArray){     
+                       nBeamMode = beamModeArray->GetEntries();        
+                       if (nBeamMode==0){
+                               AliInfo("Found zero entries for the Beam Mode, leaving it empty");
+                       }
+                       else{
+                               for (Int_t iBeamMode = 0; iBeamMode<nBeamMode; iBeamMode++){
+                                       AliDCSArray* beamMode = (AliDCSArray*)beamModeArray->At(iBeamMode);
+                                       if (beamMode){
+                                               if (beamMode->GetTimeStamp()<=timeStart && beamMode->GetTimeStamp()>=timeBeamModeStart){// taking always the very last entry: of two measurements have the same timestamp, the last one is taken
+                                                       timeBeamModeStart = beamMode->GetTimeStamp();
+                                                       indexBeamMode = iBeamMode;
+                                                       foundBeamModeStart = kTRUE;
+                                               }
+                                               else {
+                                                       break;
+
+                                               }
+                                       }
+                               }
+                               if (!foundBeamModeStart){
+                                       AliInfo("No value for the Beam Mode found before start of run, the Beam Mode will remain empty");
+                               }
+                               else {
+                                       AliDCSArray* beamMode = (AliDCSArray*)beamModeArray->At(indexBeamMode);
+                                       TObjString* beamModeString = beamMode->GetStringArray(0);
+                                       AliInfo(Form("LHC State (corresponding to BeamMode) = %s (set at %f)",(beamModeString->String()).Data(),beamMode->GetTimeStamp()));
+                                       grpobj->SetLHCState(beamModeString->String());
+                                       if (indexBeamMode < nBeamMode-1){
+                                               AliDCSArray* beamMode1 = (AliDCSArray*)beamModeArray->At(indexBeamMode+1);
+                                               if (beamMode1){
+                                                       if (beamMode1->GetTimeStamp()<=timeStart){
+                                                               AliError("you did not choose the correct value! there is still something before (or at) SOR, but later than this!");
+                                                       }
+                                                       else if (beamMode1->GetTimeStamp()>timeStart && beamMode1->GetTimeStamp()<=timeEnd){
+                                                               timeBeamModeEnd = beamMode1->GetTimeStamp();
+                                                               TObjString* beamModeString1 = beamMode1->GetStringArray(0);
+                                                               TString bmString0 = beamModeString->String();
+                                                               TString bmString1 = beamModeString1->String();
+                                                               if (bmString0.CompareTo(bmString1.Data(),TString::kIgnoreCase) == -1){
+                                                                       AliWarning(Form("The beam mode changed from %s to %s during the run at timestamp %f! Setting it to %s and keeping track of the time of the change to set MaxTimeLHCValidity afterward",bmString0.Data(), bmString1.Data(), timeBeamModeEnd, bmString0.Data()));
+                                                                       flagBeamMode = kTRUE;
+                                                               }
+                                                       }
+                                               }
+                                               else {
+                                                       AliInfo("Invalid pointer for the first entry for Beam Mode after the first valid one, not considering anything after what has already been found");
+                                               }
+                                       }
+                               }
+                       }
+                       delete beamModeArray;
+               }
+               else{
+                       AliError("Beam mode array not found in LHC Data file!!!");
+               }
+               
+               // MachineMode
+               Log("*************MachineMode ");
+               TObjArray* machineModeArray = lhcReader.ReadSingleLHCDP(fileName.Data(),fgkLHCDataPoints[1]);
+               Int_t nMachineMode = -1;
+               if (machineModeArray){
+                       nMachineMode = machineModeArray->GetEntries();
+                       if (nMachineMode==0){
+                               AliInfo("No Machine Mode found, leaving it empty");
+                       }
+                       else{
+                               for (Int_t iMachineMode = 0; iMachineMode<nMachineMode; iMachineMode++){
+                                       AliDCSArray* machineMode = (AliDCSArray*)machineModeArray->At(iMachineMode);
+                                       if (machineMode){
+                                               if (machineMode->GetTimeStamp()<=timeStart && machineMode->GetTimeStamp()>=timeMachineModeStart){// taking always the very last entry: of two measurements have the same timestamp, the last one is taken
+                                                       timeMachineModeStart = machineMode->GetTimeStamp();
+                                                       indexMachineMode = iMachineMode;
+                                                       foundMachineModeStart = kTRUE;
+                                               }
+                                               else{
+                                                       break;
+                                               }
+                                       }
+                               }
+                               if (!foundMachineModeStart){
+                                       AliInfo("No value for the Machine Mode found before start of run, the Machine Mode will remain empty");
+                               }
+                               else {
+                                       AliDCSArray* machineMode = (AliDCSArray*)machineModeArray->At(indexMachineMode);
+                                       TObjString* machineModeString = machineMode->GetStringArray(0);
+                                       AliInfo(Form("MachineMode = %s (set at %f)",(machineModeString->String()).Data(),machineMode->GetTimeStamp()));
+                                       grpobj->SetMachineMode(machineModeString->String());
+                                       if (indexMachineMode < nMachineMode-1){
+                                               AliDCSArray* machineMode1 = (AliDCSArray*)machineModeArray->At(indexMachineMode+1);
+                                               if (machineMode1){
+                                                       if (machineMode1->GetTimeStamp()>timeStart && machineMode1->GetTimeStamp()<=timeEnd){
+                                                               timeMachineModeEnd = machineMode1->GetTimeStamp();
+                                                               TObjString* machineModeString1 = machineMode1->GetStringArray(0);
+                                                               TString mmString0 = machineModeString->String();
+                                                               TString mmString1 = machineModeString1->String();
+                                                               if (mmString0.CompareTo(mmString1.Data(),TString::kIgnoreCase) == -1){
+                                                                       AliWarning(Form("The machine mode changed from %s to %s during the run at timestamp %f! Setting it to %s and keeping track of the time of the change to set MaxTimeLHCValidity afterward",mmString0.Data(),mmString1.Data(),timeMachineModeEnd,mmString0.Data()));
+                                                                       flagMachineMode = kTRUE;
+                                                               }
+                                                       }
+                                               }
+                                               else {
+                                                       AliInfo("Invalid pointer for the first entry for Machine Mode after the first valid one, not considering anything after what has already been found");
+                                               }
+                                       }
+                               }
+                       }
+                       delete machineModeArray;
+               }
+               else{
+                       AliError("Machine mode array not found in LHC Data file!!!");
+               }
+               
+               // BeamType1 and BeamType2 - both put in the same string
+               Log("*************BeamType ");
+               TObjArray* beamArray = lhcReader.ReadSingleLHCDP(fileName.Data(),fgkLHCDataPoints[3]);
+               if (beamArray){                 
+                       Int_t nBeam = beamArray->GetEntries();
+                       if (nBeam==0){
+                               AliInfo("No Beam Type found, leaving it empty");
+                       }
+                       else{
+                               for (Int_t iBeam = 0; iBeam<nBeam; iBeam++){
+                                       AliDCSArray* beam = (AliDCSArray*)beamArray->At(iBeam);
+                                       if (beam){
+                                               if (beam->GetTimeStamp()<=timeStart && beam->GetTimeStamp()>=timeBeamStart){// taking always the very last entry: of two measurements have the same timestamp, the last one is taken
+                                                       timeBeamStart = beam->GetTimeStamp();
+                                                       indexBeam = iBeam;
+                                                       foundBeamStart = kTRUE;
+                                               }
+                                               else{
+                                                       break;
+                                               }
+                                       }
+                               }
+                               if (!foundBeamStart){
+                                       AliInfo("No value for the Beam Type found before start of run, the Machine Mode will remain empty");
+                               }
+                               else {
+                                       AliDCSArray* beam = (AliDCSArray*)beamArray->At(indexBeam);
+                                       TObjString* beamString = beam->GetStringArray(0);
+                                       TString beamType = beamString->String();
+                                       AliInfo(Form("Beam Type = %s",beamType.Data()));        
+                                       if (beamType.CompareTo("PROTON",TString::kIgnoreCase) == 0){
+                                               AliInfo("Setting beam type to p-p");
+                                               grpobj->SetBeamType("p-p");
+                                       }
+                                       else { // if there is no PROTON beam, we suppose it is Pb, and we put A-A
+                                               AliInfo("Setting beam type to A-A");
+                                               grpobj->SetBeamType("A-A");
+                                       }
+                                       /*
+                                         else if (beamType.CompareTo("LEAD82",TString::kIgnoreCase) == 0){
+                                               AliInfo("Setting beam type to Pb-Pb");
+                                               grpobj->SetBeamType("Pb-Pb");
+                                       }
+                                       else{
+                                               AliError("Beam Type not known, leaving it empty");
+                                       }
+                                       */
+                                       if (indexBeam < nBeam-1){
+                                               AliDCSArray* beam1 = (AliDCSArray*)beamArray->At(indexBeam+1);
+                                               if (beam1){
+                                                       if (beam1->GetTimeStamp()>timeStart && beam1->GetTimeStamp()<=timeEnd){
+                                                               timeBeamEnd = beam1->GetTimeStamp();
+                                                               TObjString* beamString1 = beam1->GetStringArray(0);
+                                                               TString beamType1 = beamString1->String();
+                                                               if (beamType.CompareTo(beamType1.Data(),TString::kIgnoreCase) == -1){
+                                                                       AliWarning(Form("The Beam Type changed from %s to %s during the run at timestamp %f! Setting it to %s and keeping track of the time of the change to set MaxTimeLHCValidity afterward",beamType.Data(),(beamString1->String()).Data(),timeBeamEnd,beamType.Data()));
+                                                                       flagBeam = kTRUE;
+                                                               }
+                                                       }
+                                               }
+                                               else {
+                                                       AliInfo("Invalid pointer for the first entry for Beam Type after the first valid one, not considering anything after what has already been found");
+                                               }
+                                       }
+                               }
+                       }
+                       delete beamArray;
+               }
+               else{
+                       AliError("Beam Type array not found in LHC Data file!!!");
+               }               
+               
+               // Setting minTimeLHCValidity
+               if (timeBeamModeEnd!=0 || timeMachineModeEnd!=0 || timeBeamEnd !=0){
+                       Double_t minTimeLHCValidity;
+                       if (flagBeamMode == kFALSE && flagMachineMode == kFALSE && flagBeam == kTRUE){ // flagBeam only true
+                               minTimeLHCValidity = timeBeamEnd;
+                       }
+                       else if (flagBeamMode == kFALSE && flagMachineMode == kTRUE && flagBeam == kFALSE){ // flagMachineMode only true
+                               minTimeLHCValidity = timeMachineModeEnd;
+                       }
+                       else if (flagBeamMode == kTRUE && flagMachineMode == kFALSE && flagBeam == kFALSE){ // flagBeamMode only true
+                               minTimeLHCValidity = timeBeamModeEnd;
+                       }
+                       else if (flagBeamMode == kFALSE && flagMachineMode == kTRUE && flagBeam == kTRUE){ // flagBeam and flagMachineMode only true
+                               minTimeLHCValidity= TMath::Min(timeBeamEnd,timeMachineModeEnd);
+                       }
+                       else if (flagBeamMode == kTRUE && flagMachineMode == kFALSE && flagBeam == kTRUE){ // flagBeam and flagBeamMode only true
+                               minTimeLHCValidity= TMath::Min(timeBeamEnd,timeBeamModeEnd);
+                       }
+                       else if (flagBeamMode == kTRUE && flagMachineMode == kTRUE && flagBeam == kFALSE){ // flagMachineMode and flagBeamMode only true
+                               minTimeLHCValidity= TMath::Min(timeMachineModeEnd,timeBeamModeEnd);
+                       }
+                       else {
+                               Double_t arrayTimes[3] = {timeBeamModeEnd,timeMachineModeEnd,timeBeamEnd};// flagMachineMode and flagBeamMode and flagBeam 
+                               minTimeLHCValidity= TMath::MinElement(3,arrayTimes);
+                       }
+                       AliWarning(Form("Setting MaxTimeLHCValidity to %f",minTimeLHCValidity));
+                       grpobj->SetMaxTimeLHCValidity(minTimeLHCValidity);
+               }
+               
+               // Processing data to go to AliLHCData object
+               AliLHCData* dt = new AliLHCData(fileName.Data(),timeStart,timeEnd);
+               // storing AliLHCData in OCDB
+               if (dt){
+                 AliInfo(Form("Filled %d records to AliLHCData object",dt->GetData().GetEntriesFast()));
+                 AliCDBMetaData md;
+                 md.SetResponsible("Ruben Shahoyan");
+                 md.SetComment("LHC data from the GRP preprocessor.");
+                 Bool_t result = kTRUE;
+                 result = Store("GRP", "LHCData", dt, &md); 
+                 delete dt;
+                 if (!result){
+                       Log(Form("Problems in storing LHC Data - but not going into Error"));
+                 }
+               }
+
+               // processing LHC Phase
+
+               TObjArray *beam1phase = lhcReader.ReadSingleLHCDP(fileName.Data(),fgkLHCDataPoints[4]);
+               TObjArray *beam2phase = lhcReader.ReadSingleLHCDP(fileName.Data(),fgkLHCDataPoints[5]);
+               if (beam1phase == 0x0 || beam2phase == 0x0){
+                       Log(Form("Problems in retrieving LHC Clock data from LHC file"));
+                       return 4;
+               }                       
+               AliLHCClockPhase *phaseObj = ProcessLHCClockPhase(beam1phase,beam2phase,timeEnd);
+               if (phaseObj){
+                       AliInfo(Form("LHC Phase found"));
+                       AliCDBMetaData mdPhase;
+                       mdPhase.SetResponsible("Cvetan Cheshkov");
+                       mdPhase.SetComment("LHC Clock Phase");
+                       Bool_t result = kTRUE;
+                       result = Store("Calib", "LHCClockPhase", phaseObj, &mdPhase); 
+                       delete phaseObj;
+                       if (!result) return 3;
+               }
+               else return 4;
+       }
+       
+       else {
+               AliError("No LHCData file found in DCS FXS");
+               return 1;
+       }
+
+       return 0;
+}
+
+//_______________________________________________________________
+
+UInt_t AliGRPPreprocessor::ProcessSPDMeanVertex()
+{
+       //
+       //Getting the SPD Mean Vertex
+       //
+
+       TList* list = GetForeignFileSources("SPD", kDAQ, "VertexDiamond");
+       Bool_t storeResult = kTRUE;
+       if (list !=0x0 && list->GetEntries()!=0)
+               {
+                       AliInfo("The following sources produced files with the id VertexDiamond from SPD");
+                       list->Print();
+                       for (Int_t jj=0;jj<list->GetEntries();jj++){
+                               TObjString * str = dynamic_cast<TObjString*> (list->At(jj)); 
+                               if (!str){
+                                       AliError(Form("Expecting a TObjString in the list for the %d-th source, but something else was found.",jj));
+                                       continue;
+                               }
+                               AliInfo(Form("found source %s", str->String().Data()));
+                               TString fileNameRun = GetForeignFile("SPD", kDAQ, "VertexDiamond", str->GetName());
+                               if (fileNameRun.Length()>0){
+                                       AliInfo(Form("Got the file %s", fileNameRun.Data()));
+                                       TFile daqFile(fileNameRun.Data(),"READ");
+                                       if (daqFile.IsOpen()) {
+                                               AliESDVertex* meanVtx = dynamic_cast<AliESDVertex*>(daqFile.Get("MeanVertexPos"));
+                                               if (meanVtx){
+                                                       meanVtx->Print();       
+                                                       // storing in the OCDB 
+                                                       AliCDBMetaData md;
+                                                       md.SetResponsible("Cvetan Cheshkov");
+                                                       md.SetComment("SPD Mean Vertex");                                       
+                                                       storeResult = Store("Calib", "MeanVertexSPD", meanVtx, &md, 0, kTRUE); 
+                                               }
+                                               else{
+                                                       AliWarning("No SPD Mean Vertex object found in file");
+                                               } 
+                                       }
+                                       else {
+                                               AliError("Can't open file");
+                                               storeResult = kFALSE;
+                                       }
+                               }
+                               else{
+                                       AliWarning("No file found for current source for SPD Mean Vertex");
+                               }
+                       }
+               }
+       else {
+               AliWarning("No list found for SPD Mean Vertex");
+       }
+
+       if (list) delete list;
+
+       return storeResult;
+}
+
+
 //_______________________________________________________________
 
 Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
@@ -521,7 +1097,7 @@ Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
                nparameter++;
        } 
        else {
-               Log(Form("Start time not put in logbook, setting to invalid in GRP entry!"));
+               Log(Form("Start time not put in logbook, setting to invalid in GRP entry, and causing an error!"));
        }
 
        if (timeEnd != 0){
@@ -530,36 +1106,22 @@ Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
                nparameter++;
        } 
        else {
-               Log(Form("End time not put in logbook, setting to invalid in GRP entry!"));
+               Log(Form("End time not put in logbook, setting to invalid in GRP entry, and causing an error!"));
        }
 
        if (beamEnergy != 0){
-               grpObj->SetBeamEnergy(beamEnergy);
-               Log(Form("Beam Energy for run %d: %f",fRun, beamEnergy));
-               //if ((runType == "PHYSICS" && beamType!="Cosmics")){
-               if ((runType == "PHYSICS" && !beamType.IsNull())){   // if beamType is NOT Null, then we're not in a Cosmics run
-                       nparameter++; // increasing nparameters only in case we're in PHYSICS runs with beamType != NULL
-               }
+               Log(Form("Beam Energy for run %d: %f (NOT USING IT TO FILL THE GRP OBJECT, taking it from the LHC file)",fRun, beamEnergy));
        } 
        else {
-               //if ((runType == "PHYSICS" && beamType!="Cosmics")){
-               if ((runType == "PHYSICS" && !beamType.IsNull())){ // if beamType is NOT Null, then we're not in a Cosmics run
-                       Log(Form("Beam Energy not put in logbook, setting to invalid in GRP entry, and producing an error (beamType = %s, runType = %s)",beamType.Data(), runType.Data()));
-               }
-               else{
-                       Log(Form("Beam Energy not put in logbook, setting to invalid in GRP entry, but not producing any error (beamType = NULL, runType = %s)", runType.Data()));
-               }
+               Log(Form("Beam Energy not put in logbook, but not using it anyway for the GRP object (taking it from the LHC file)"));
        }
 
                
        if (beamType.Length() != 0){
-               grpObj->SetBeamType(beamType);
-               Log(Form("Beam Type for run %d: %s",fRun, beamType.Data()));
-               nparameter++; 
+               Log(Form("Beam Type for run %d: %s (NOT USING IT TO FILL THE GRP OBJECT, taking it from the LHC file)",fRun, beamType.Data()));
        } 
        else {
-               Log(Form("Beam Type not put in logbook, setting to invalid in GRP entry! Not producing any error, considering this as a Cosmics run"));
-               nparameter++;
+               Log(Form("Beam Type not put in logbook, but not using it anyway for the GRP entry (taking it from the LHC file)"));
        }
                
        if (numberOfDetectors != 0){
@@ -568,7 +1130,7 @@ Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
                nparameter++;
        } 
        else {
-               Log(Form("Number Of Detectors not put in logbook, setting to invalid in GRP entry!"));
+               Log(Form("Number Of Detectors not put in logbook, setting to invalid in GRP entry, and causing an error!"));
        }
 
        if (detectorMask != 0){
@@ -577,7 +1139,7 @@ Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
                nparameter++;
        } 
        else {
-               Log(Form("Detector Mask not put in logbook, setting to invalid in GRP entry!"));
+               Log(Form("Detector Mask not put in logbook, setting to invalid in GRP entry, and causing an error!"));
        }
 
        if (lhcPeriod.Length() != 0) {
@@ -586,7 +1148,7 @@ Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
                nparameter++;
        } 
        else {
-               Log(Form("LHCperiod not put in logbook, setting to invalid in GRP entry!"));
+               Log(Form("LHCperiod not put in logbook, setting to invalid in GRP entry, and causing an error!"));
        }
        if (runType.Length() != 0) {
                grpObj->SetRunType(runType);
@@ -594,7 +1156,7 @@ Int_t AliGRPPreprocessor::ProcessDaqLB(AliGRPObject* grpObj)
                nparameter++;
        } 
        else {
-               Log(Form("Run Type not put in logbook, setting to invalid in GRP entry!"));
+               Log(Form("Run Type not put in logbook, setting to invalid in GRP entry, and causing an error!"));
        }
 
        return nparameter;
@@ -607,6 +1169,7 @@ UInt_t AliGRPPreprocessor::ProcessDaqFxs()
        //======DAQ FXS======//
        
        AliRawEventHeaderV3_9::Class()->IgnoreTObjectStreamer(); // to avoid trying reading TObject store in AliRawEventHeaderV3_9 - temporary fix 
+       AliRawEventHeaderV3_11::Class()->IgnoreTObjectStreamer(); // to avoid trying reading TObject store in AliRawEventHeaderV3_11 - temporary fix 
        TList* list = GetFileSources(kDAQ);  
        if (!list) {
                Log("No raw data tag list: connection problems with DAQ FXS logbook!");
@@ -740,9 +1303,11 @@ UInt_t AliGRPPreprocessor::ProcessDcsFxs(TString partition, TString detector)
                                metaData.SetComment("CTP scalers");
                                if (!Store("CTP","Scalers", scalers, &metaData, 0, 0)) {
                                        Log("Unable to store the CTP scalers object to OCDB!");
+                                       delete scalers;                                 
                                        return 1;
                                }
                        }
+                       delete scalers;
                }
        }
        
@@ -765,18 +1330,17 @@ Int_t AliGRPPreprocessor::ProcessDcsDPs(TMap* valueMap, AliGRPObject* grpObj)
        //
 
        Int_t entries = 0;  // counting the entries that are in the DCS DB, not taking care whether they have values or not
-       Int_t nLHCEntries = 0;
        Int_t nL3Entries = 0;
        Int_t nDipoleEntries = 0;
        Int_t nEnvEntries = 0;
        Int_t nHallProbesEntries = 0;
-       nLHCEntries = ProcessLHCDPs(valueMap, grpObj);
        nL3Entries = ProcessL3DPs(valueMap, grpObj);
        nDipoleEntries = ProcessDipoleDPs(valueMap, grpObj);
        nEnvEntries = ProcessEnvDPs(valueMap, grpObj);
        nHallProbesEntries = ProcessHPDPs(valueMap, grpObj);
        grpObj->SetPolarityConventionLHC();  // after the dipole cables swap we comply with LHC convention
-       entries = nLHCEntries + nL3Entries + nDipoleEntries + nEnvEntries + nHallProbesEntries;
+       Log(Form("L3Entries = %d, nDipoleEntries =%d, nEnvEntries = %d, nHallProbesEntries = %d", nL3Entries, nDipoleEntries, nEnvEntries, nHallProbesEntries));
+       entries = nL3Entries + nDipoleEntries + nEnvEntries + nHallProbesEntries;
        return entries;
 
 }
@@ -791,6 +1355,7 @@ Int_t AliGRPPreprocessor::ProcessL3DPs(const TMap* valueMap, AliGRPObject* grpOb
        // L3 info
 
        Int_t nL3Entries = 0;
+
        TObjArray *array = 0x0;
        Int_t indexDP = -1;
        Bool_t isZero = kTRUE; // flag to monitor L3Current. If set to true, the magnet is OFF, and the polarity can change
@@ -819,7 +1384,10 @@ Int_t AliGRPPreprocessor::ProcessL3DPs(const TMap* valueMap, AliGRPObject* grpOb
                                floatDCS = 0x0;
                        }
                }
-               if (!outOfRange) nL3Entries++;
+               if (!outOfRange) {
+                       nL3Entries++;
+                       ffailedDPs->RemoveAt(indexDP);
+               }
        }
 
        if (array) array = 0x0;
@@ -840,10 +1408,12 @@ Int_t AliGRPPreprocessor::ProcessL3DPs(const TMap* valueMap, AliGRPObject* grpOb
                        if (change == kFALSE){
                                grpObj->SetL3Polarity(charDCS);
                                AliInfo(Form("%s set to %d",fgkDCSDataPoints[indexDP],(Int_t)(grpObj->GetL3Polarity())));
+                               ffailedDPs->RemoveAt(indexDP);
                                nL3Entries++;
                        }
                        else if (isZero){
                                AliInfo(Form("%s set to invalid, but magnet was OFF (according to the current), DP not considered wrong",fgkDCSDataPoints[indexDP]));
+                               ffailedDPs->RemoveAt(indexDP);
                                nL3Entries++;
                        }
                        else {
@@ -892,7 +1462,10 @@ Int_t AliGRPPreprocessor::ProcessDipoleDPs(const TMap* valueMap, AliGRPObject* g
                                floatDCS = 0x0;
                        }
                }
-               if (!outOfRange) nDipoleEntries++;
+               if (!outOfRange) {
+                       nDipoleEntries++;
+                       ffailedDPs->RemoveAt(indexDP);
+               }
        }
 
        if (array) array = 0x0;
@@ -913,10 +1486,12 @@ Int_t AliGRPPreprocessor::ProcessDipoleDPs(const TMap* valueMap, AliGRPObject* g
                        if (!change){
                                grpObj->SetDipolePolarity(charDCS);
                                AliInfo(Form("%s set to %d",fgkDCSDataPoints[indexDP],(Int_t)(grpObj->GetDipolePolarity())));
+                               ffailedDPs->RemoveAt(indexDP);
                                nDipoleEntries++;
                        }
                        else if (isZero){
                                AliInfo(Form("%s set to invalid, but magnet was OFF (according to the current), DP not considered wrong",fgkDCSDataPoints[indexDP]));
+                               ffailedDPs->RemoveAt(indexDP);
                                nDipoleEntries++;
                        }
                        else{
@@ -964,7 +1539,10 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
                                floatDCS = 0x0;
                        }
                }
-               if (!outOfRange) nEnvEntries++;
+               if (!outOfRange) {
+                       ffailedDPs->RemoveAt(indexDP);
+                       nEnvEntries++;
+               }
        }
 
        if (array) array = 0x0;
@@ -981,6 +1559,8 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
        indexDP = kCavernAtmosPressure;
        AliDCSSensor* sensorCavernP2 = dcsSensorArray->GetSensor(fgkDCSDataPoints[indexDP]);
        TGraph* graph = sensorCavernP2->GetGraph();
+       AliDebug(3,Form("index = %d",indexDP));
+       AliDebug(3,Form("name = %s",fgkDCSDataPoints[indexDP]));
        AliDebug(2,Form("graph = %p",graph));
        AliDebug(3,Form("sensorCavernP2 = %p", sensorCavernP2));
        if(sensorCavernP2->GetFit() || graph) {
@@ -991,6 +1571,7 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
                        Log(Form("Fit for sensor %s not found, but the graph is there - NOT going into error",fgkDCSDataPoints[indexDP]));
                }
                grpObj->SetCavernAtmosPressure(sensorCavernP2);
+               ffailedDPs->RemoveAt(indexDP);
                nEnvEntries++;
        } 
        //if (sensorP2) delete sensorP2;
@@ -1002,6 +1583,8 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
        indexDP = kSurfaceAtmosPressure;
        AliDCSSensor* sensorP2 = dcsSensorArray->GetSensor(fgkDCSDataPoints[indexDP]);
        graph = sensorP2->GetGraph();
+       AliDebug(3,Form("index = %d",indexDP));
+       AliDebug(3,Form("name = %s",fgkDCSDataPoints[indexDP]));
        AliDebug(2,Form("graph = %p",graph));   
        AliDebug(3,Form("sensorP2 = %p", sensorP2));
        if(sensorP2->GetFit() || graph) {
@@ -1012,6 +1595,7 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
                        Log(Form("Fit for sensor %s not found, but the graph is there - NOT going into error",fgkDCSDataPoints[indexDP]));
                }
                grpObj->SetSurfaceAtmosPressure(sensorP2);
+               ffailedDPs->RemoveAt(indexDP);
                nEnvEntries++;
        } 
        //if (sensorP2) delete sensorP2;
@@ -1022,7 +1606,9 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
        AliInfo(Form("==========CavernAtmosPressure2==========="));
        indexDP = kCavernAtmosPressure2;
        AliDCSSensor* sensorCavernP22 = dcsSensorArray->GetSensor(fgkDCSDataPoints[indexDP]);
-       graph = sensorP2->GetGraph();
+       graph = sensorCavernP22->GetGraph();
+       AliDebug(3,Form("index = %d",indexDP));
+       AliDebug(3,Form("name = %s",fgkDCSDataPoints[indexDP]));
        AliDebug(2,Form("graph = %p",graph));   
        AliDebug(3,Form("sensorCavernP2_2 = %p", sensorCavernP22));
        if(sensorCavernP22->GetFit() || graph) {
@@ -1033,6 +1619,7 @@ Int_t AliGRPPreprocessor::ProcessEnvDPs(TMap* valueMap, AliGRPObject* grpObj)
                        Log(Form("Fit for sensor %s not found, but the graph is there - NOT going into error",fgkDCSDataPoints[indexDP]));
                }
                grpObj->SetCavernAtmosPressure2(sensorCavernP22);
+               ffailedDPs->RemoveAt(indexDP);
                nEnvEntries++;
        } 
        //if (sensorP2) delete sensorP2;
@@ -1087,7 +1674,10 @@ Int_t AliGRPPreprocessor::ProcessHPDPs(const TMap* valueMap, AliGRPObject* grpOb
                                        floatDCS = 0x0;
                                }
                        }
-                       if (!outOfRange) nHPEntries++;
+                       if (!outOfRange) {
+                               ffailedDPs->RemoveAt(indexDP + fgkDCSDPHallTopShift);  // 7 = shift in the complete list of DPs to get to the Hall Probes
+                               nHPEntries++;
+                       }
                }
        }
                
@@ -1095,126 +1685,6 @@ Int_t AliGRPPreprocessor::ProcessHPDPs(const TMap* valueMap, AliGRPObject* grpOb
        return nHPEntries;
 }
 
-//_______________________________________________________________
-
-Int_t AliGRPPreprocessor::ProcessLHCDPs(const TMap* valueMap, AliGRPObject* grpObj)
-{
-
-       //
-       // processing of LHC related DCS DPs, i.e.:
-       // LHCState
-       // LHCLuminosity
-       // BeamIntensity
-       //
-
-       Int_t nLHCEntries = 0;
-       TObjArray *array = 0x0;
-       Int_t indexDP = -1;
-
-       AliInfo(Form("==========LHCState==========="));
-       indexDP = kLHCState;
-       array = (TObjArray *)valueMap->GetValue(fgkDCSDataPoints[indexDP]);
-       if(!array) {
-               Log(Form("%s not found in the map!!!",fgkDCSDataPoints[indexDP]));
-       } 
-       else {
-               if (array->GetEntries() == 0){
-                       AliError(Form("No entries found in array! setting %s to invalid...",fgkDCSDataPoints[indexDP]));
-               }
-               else {
-                       TString stringDCS = ProcessChar(array);
-                       if (stringDCS.Length()!=0) {
-                               Bool_t found = kFALSE;
-                               for( Int_t i=0; i<20; i+=2 ) {
-                                       if( stringDCS.CompareTo(fgkLHCState[i]) == 0 ) {
-                                               stringDCS = fgkLHCState[i+1];
-                                               found = kTRUE;
-                                               break;
-                                       }
-                               }
-                               if (found){
-                                       Log(Form("<%s> for run %d: %s",fgkDCSDataPoints[indexDP],fRun, stringDCS.Data()));
-                                       grpObj->SetLHCState(stringDCS);
-                               }
-                               else{
-                                       Log(Form("%s values found not valid!",fgkDCSDataPoints[indexDP]));
-                                       grpObj->SetLHCState(AliGRPObject::GetInvalidString());
-                               } 
-                       }
-                       else {
-                               Log(Form("%s not valid (null length), string set as invalid!",fgkDCSDataPoints[indexDP]));
-                               grpObj->SetLHCState(AliGRPObject::GetInvalidString());
-                       }         
-               }
-               nLHCEntries++;
-       }
-       
-       if (array) array = 0x0;
-
-       AliInfo(Form("==========LHCLuminosity==========="));
-       Bool_t outOfRange = kFALSE; // flag to monitor if any value collected by DCS is out of range
-       indexDP = kLHCLuminosity;
-       array = (TObjArray *)valueMap->GetValue(fgkDCSDataPoints[indexDP]);
-       if(!array) {
-               Log(Form("%s not found in the map!!!",fgkDCSDataPoints[indexDP]));
-       } 
-       else {
-               if (array->GetEntries() == 0){
-                       AliError(Form("No entries found in array! setting %s and its Spline Fit to invalid...",fgkDCSDataPoints[indexDP]));
-               }
-               else {
-                       Float_t *floatDCS = ProcessFloatAll(array);
-                       if (floatDCS != NULL){
-                               grpObj->SetLHCLuminosity(floatDCS);
-                               AliSplineFit* splfit = GetSplineFit(array,fgkDCSDataPoints[indexDP]);
-                               grpObj->SetLHCLuminositySplineFit(splfit);
-                       //              delete splfit;
-                       }
-                       else {
-                               outOfRange = kTRUE;
-                       }
-                       if (floatDCS){
-                               delete[] floatDCS;
-                               floatDCS = 0x0;
-                       }
-               }
-               if (!outOfRange) nLHCEntries++;
-       }
-
-       if (array) array = 0x0;
-
-       AliInfo(Form("==========BeamIntensity==========="));
-       if (outOfRange) outOfRange = kFALSE;  // resetting outOfRange if needed
-       indexDP = kBeamIntensity;
-       array = (TObjArray *)valueMap->GetValue(fgkDCSDataPoints[indexDP]);
-       if(!array) {
-               Log(Form("%s not found in the map!!!",fgkDCSDataPoints[indexDP]));
-       } 
-       else {
-               if (array->GetEntries() == 0){
-                       AliError(Form("No entries found in array! setting %s and its Spline Fit to invalid...",fgkDCSDataPoints[indexDP]));
-               }
-               else {
-                       Float_t *floatDCS = ProcessFloatAll(array);
-                       if (floatDCS != NULL){
-                               grpObj->SetBeamIntensity(floatDCS);
-                               AliSplineFit* splfit1 = GetSplineFit(array,fgkDCSDataPoints[indexDP]);
-                               grpObj->SetBeamIntensitySplineFit(splfit1);
-                               //delete splfit;
-                       }
-                       else{
-                               outOfRange = kTRUE;
-                       }
-                       if (floatDCS){
-                               delete[] floatDCS;
-                               floatDCS = 0x0;
-                       }
-               }
-               if (!outOfRange) nLHCEntries++;
-       }
-
-       return nLHCEntries;
-}
 //_________________________________________________________________________
 
 AliSplineFit* AliGRPPreprocessor::GetSplineFit(const TObjArray *array, const TString& stringID){
@@ -1244,10 +1714,6 @@ AliSplineFit* AliGRPPreprocessor::GetSplineFit(const TObjArray *array, const TSt
        fit->InitKnots(gr,10,10,0.0);
        fit->SplineFit(2);
        fit->Cleanup();
-       if (!fit) {
-               AliWarning(Form("%s: no fit performed",stringID.Data()));
-               return NULL;
-       } 
        return fit;
 }
 
@@ -1328,6 +1794,7 @@ Float_t* AliGRPPreprocessor::ProcessFloatAll(const TObjArray* array)
                        AliError(Form("Error! Float value found in DCS map at %d-th entry is OUT OF RANGE: value = %6.5e",i,v->GetFloat()));
                        if (v->GetFloat() < fminFloat) AliInfo(Form("The value is smaller than %6.5e",fminFloat));
                        if (v->GetFloat() > fmaxFloat) AliInfo(Form("The value is greater than %6.5e",fmaxFloat));
+                       delete [] parameters;
                        return NULL;
                }
                if(((Int_t)(v->GetTimeStamp()) >= (Int_t)GetStartTimeDCSQuery()) &&((Int_t)(v->GetTimeStamp()) <= (Int_t)GetEndTimeDCSQuery())) {
@@ -1508,6 +1975,15 @@ Float_t* AliGRPPreprocessor::ProcessFloatAll(const TObjArray* array)
                        parameters[1] = AliGRPObject::GetInvalidFloat();
        }
 
+       if (arrayValues){
+               delete [] arrayValues;
+       } 
+       if (arrayWeights){
+               delete [] arrayWeights;
+       } 
+       delete [] arrayValuesTruncMean;
+       delete [] arrayWeightsTruncMean;
+
        AliInfo(Form("(weighted) mean = %f ",parameters[0]));
        AliInfo(Form("(weighted) truncated mean = %f ",parameters[1]));
        AliInfo(Form("median = %f ",parameters[2]));
@@ -1698,6 +2174,8 @@ Float_t AliGRPPreprocessor::ProcessInt(const TObjArray* array)
                        arrayValues[i-ientrySOR] = (Float_t)v->GetInt();
                }
                aDCSArrayMean = TMath::Mean(iCountsRun,arrayValues,arrayWeights);
+               delete [] arrayValues;
+               delete [] arrayWeights;
        }
        else if (iCountsRun == 1){
                AliDCSValue* v = (AliDCSValue *)array->At(ientrySOR);
@@ -1713,6 +2191,8 @@ Float_t AliGRPPreprocessor::ProcessInt(const TObjArray* array)
                        AliDebug(2,Form("value0 = %f, with weight = %f",arrayValues[0],arrayWeights[0])); 
                        AliDebug(2,Form("value1 = %f, with weight = %f",arrayValues[1],arrayWeights[1])); 
                        aDCSArrayMean = TMath::Mean(2,arrayValues,arrayWeights);
+                       delete [] arrayValues;
+                       delete [] arrayWeights;
                }
                else{
                        AliError("Cannot calculate mean - only one value collected during the run, but no value before with which to calculate the statistical quantities");
@@ -1741,6 +2221,8 @@ Float_t AliGRPPreprocessor::ProcessInt(const TObjArray* array)
                        AliDebug(2,Form("value0 = %f, with weight = %f",arrayValues[0],arrayWeights[0])); 
                        AliDebug(2,Form("value1 = %f, with weight = %f",arrayValues[1],arrayWeights[1])); 
                        aDCSArrayMean = TMath::Mean(1,arrayValues,arrayWeights);
+                       delete [] arrayValues;
+                       delete [] arrayWeights;
                }
        }
 
@@ -1853,6 +2335,8 @@ Float_t AliGRPPreprocessor::ProcessUInt(const TObjArray* array)
                        arrayValues[i-ientrySOR] = (Float_t)v->GetUInt();
                }
                aDCSArrayMean = TMath::Mean(iCountsRun,arrayValues,arrayWeights);
+               delete [] arrayValues;
+               delete [] arrayWeights;
        }
        else if (iCountsRun == 1){
                AliDCSValue* v = (AliDCSValue *)array->At(ientrySOR);
@@ -1868,6 +2352,8 @@ Float_t AliGRPPreprocessor::ProcessUInt(const TObjArray* array)
                        AliDebug(2,Form("value0 = %f, with weight = %f",arrayValues[0],arrayWeights[0])); 
                        AliDebug(2,Form("value1 = %f, with weight = %f",arrayValues[1],arrayWeights[1])); 
                        aDCSArrayMean = TMath::Mean(2,arrayValues,arrayWeights);
+                       delete [] arrayValues;
+                       delete [] arrayWeights;
                }
                else{
                        AliError("Cannot calculate mean - only one value collected during the run, but no value before with which to calculate the statistical quantities");
@@ -1896,6 +2382,8 @@ Float_t AliGRPPreprocessor::ProcessUInt(const TObjArray* array)
                        AliDebug(2,Form("value0 = %f, with weight = %f",arrayValues[0],arrayWeights[0])); 
                        AliDebug(2,Form("value1 = %f, with weight = %f",arrayValues[1],arrayWeights[1])); 
                        aDCSArrayMean = TMath::Mean(1,arrayValues,arrayWeights);
+                       delete [] arrayValues;
+                       delete [] arrayWeights;
                }
        }
 
@@ -1970,7 +2458,7 @@ Int_t AliGRPPreprocessor::ReceivePromptRecoParameters(UInt_t run, const char* db
        
        // main logbook
        TString sqlQuery;
-       sqlQuery.Form("SELECT DAQ_time_start, run_type, detectorMask, L3_magnetCurrent, Dipole_magnetCurrent FROM logbook WHERE run = %d", run);
+       sqlQuery.Form("SELECT DAQ_time_start, run_type, detectorMask, L3_magnetCurrent, Dipole_magnetCurrent,beamType FROM logbook WHERE run = %d", run);
        TSQLResult* result = server->Query(sqlQuery);
        if (!result)
                {
@@ -1998,12 +2486,16 @@ Int_t AliGRPPreprocessor::ReceivePromptRecoParameters(UInt_t run, const char* db
        TString detectorMaskString(row->GetField(2));
        TString l3CurrentString(row->GetField(3));
        TString dipoleCurrentString(row->GetField(4));
+       TString beamTypeString(row->GetField(5));
        time_t timeStart = (time_t)(timeStartString.Atoi());
        UInt_t detectorMask = (UInt_t)(detectorMaskString.Atoi());
        Float_t l3Current = (Float_t)(TMath::Abs(l3CurrentString.Atof()));
        Float_t dipoleCurrent = (Float_t)(TMath::Abs(dipoleCurrentString.Atof()));
        Char_t l3Polarity = (l3CurrentString.Atof() < 0) ? 1 : 0;
        Char_t dipolePolarity = (dipoleCurrentString.Atof() < 0) ? 1 : 0;
+       if (beamTypeString.CompareTo("Pb-Pb",TString::kIgnoreCase) == 0){
+               beamTypeString="A-A";
+       }
        
        AliGRPObject * grpObj = new AliGRPObject();
        grpObj->SetTimeStart(timeStart); 
@@ -2013,6 +2505,8 @@ Int_t AliGRPPreprocessor::ReceivePromptRecoParameters(UInt_t run, const char* db
        grpObj->SetDipoleCurrent(dipoleCurrent,(AliGRPObject::Stats)0);
        grpObj->SetL3Polarity(l3Polarity);
        grpObj->SetDipolePolarity(dipolePolarity);
+       grpObj->SetPolarityConventionLHC();  // after the dipole cables swap we comply with LHC convention
+       grpObj->SetBeamType(beamTypeString);
 
        delete row;
        row = 0;
@@ -2173,3 +2667,129 @@ Int_t AliGRPPreprocessor::ReceivePromptRecoParameters(UInt_t run, const char* db
        
        return lastRun;
 }
+//------------------------------------------------------------------------------------------------------
+Float_t AliGRPPreprocessor::ProcessEnergy(TObjArray* const array, Double_t timeStart){
+
+       //
+       // Method to processo LHC Energy information
+       // Only the first value is returned, provided that it is withing DAQ_time_start and DAQ_time_end
+       //
+
+       Int_t nCounts = array->GetEntries();
+       Float_t energy = -1;
+       Double_t timeEnergy = -1;
+       Int_t indexEnergy = -1;
+       Bool_t foundEnergy = kFALSE;
+
+       AliDebug(2,Form("Energy measurements = %d\n",nCounts));
+       if (nCounts ==0){
+               AliWarning("No Energy values found! Beam Energy remaining invalid!");
+       }
+       else{
+               for (Int_t i = 0; i < nCounts; i++){
+                       AliDCSArray *dcs = (AliDCSArray*)array->At(i);
+                       if (dcs){
+                               if (dcs->GetTimeStamp()<=timeStart && dcs->GetTimeStamp()>=timeEnergy){// taking always the very last entry: of two measurements have the same timestamp, the last one is taken
+                                       timeEnergy = dcs->GetTimeStamp();
+                                       indexEnergy = i;
+                                       foundEnergy = kTRUE;
+                               }
+                               else{
+                                       break;
+                               }
+                       }
+               }
+               if (!foundEnergy){
+                       AliInfo("No value for the Energy found before start of run, the Energy will remain invalid");
+               }
+               else {
+                       AliDCSArray* dcs = (AliDCSArray*)array->At(indexEnergy);
+                       energy = (Float_t)(TMath::Nint(((Double_t)(dcs->GetInt(0)))*120/1000)); // sqrt(s)/2 energy in GeV
+                       AliInfo(Form("Energy value found = %d (at %f), converting --> sqrt(s)/2 = %f (GeV)", dcs->GetInt(0),dcs->GetTimeStamp(),energy));
+               }
+       }
+
+       return energy;
+}
+//------------------------------------------------------------------------------------------------------
+AliLHCClockPhase* AliGRPPreprocessor::ProcessLHCClockPhase(TObjArray *beam1phase,TObjArray *beam2phase, Double_t timeEnd)
+{
+  //
+  // Method to process LHC-Clock Phase data
+  // Only the values between DAQ_time_start and DAQ_time_end are kept
+  //
+  AliLHCClockPhase *phaseObj = new AliLHCClockPhase;
+
+  Bool_t foundBeam1Phase = kFALSE, foundBeam2Phase = kFALSE;
+  const Float_t threshold = 0.050; // we store the measurement only in case they differ with more 50ps from the previous one 
+
+  TString timeCreatedStr = GetRunParameter("time_created");
+  Double_t timeCreated = timeCreatedStr.Atof();
+
+  Int_t nCounts = beam1phase->GetEntries();
+  AliDebug(2,Form("Beam1 phase measurements = %d\n",nCounts));
+  if (nCounts ==0){
+    AliWarning("No beam1 LHC clock phase values found!");
+    delete phaseObj;
+    return NULL;
+  }
+  else{
+    Double_t prevPhase = 0;
+    for (Int_t i = 0; i < nCounts; i++){
+      AliDCSArray *dcs = (AliDCSArray*)beam1phase->At(i);
+      if (dcs){
+             //if (dcs->GetTimeStamp()>=timeStart && dcs->GetTimeStamp()<=timeEnd) {
+             if (dcs->GetTimeStamp()>=timeCreated && dcs->GetTimeStamp()<=timeEnd) {
+         if ((i == 0) || (i == (nCounts-1)) ||
+             !foundBeam1Phase ||
+             (TMath::Abs(dcs->GetDouble(0)-prevPhase) > threshold)) {
+           prevPhase = dcs->GetDouble(0);
+           foundBeam1Phase = kTRUE;
+           AliInfo(Form("B1 Clk Phase = %f at TS = %f",
+                        (Float_t)dcs->GetDouble(0),dcs->GetTimeStamp()));  
+           phaseObj->AddPhaseB1DP((UInt_t)dcs->GetTimeStamp(),(Float_t)dcs->GetDouble(0));
+         }
+       }
+      }
+    }
+    if (!foundBeam1Phase){
+      AliError("No beam1 LHC clock phase values found within the run!");
+      delete phaseObj;
+      return NULL;
+    }
+  }
+
+  nCounts = beam2phase->GetEntries();
+  AliDebug(2,Form("Beam2 phase measurements = %d\n",nCounts));
+  if (nCounts ==0){
+    AliWarning("No beam2 LHC clock phase values found!");
+    delete phaseObj;
+    return NULL;
+  }
+  else{
+    Double_t prevPhase = 0;
+    for (Int_t i = 0; i < nCounts; i++){
+      AliDCSArray *dcs = (AliDCSArray*)beam2phase->At(i);
+      if (dcs){
+       if (dcs->GetTimeStamp()>=timeCreated && dcs->GetTimeStamp()<=timeEnd) {
+         if ((i == 0) || (i == (nCounts-1)) ||
+             !foundBeam2Phase ||
+             (TMath::Abs(dcs->GetDouble(0)-prevPhase) > threshold)) {
+           prevPhase = dcs->GetDouble(0);
+           foundBeam2Phase = kTRUE;
+           AliInfo(Form("B2 Clk Phase = %f at TS = %f",
+                        (Float_t)dcs->GetDouble(0),dcs->GetTimeStamp()));  
+           phaseObj->AddPhaseB2DP((UInt_t)dcs->GetTimeStamp(),(Float_t)dcs->GetDouble(0));
+         }
+       }
+      }
+    }
+    if (!foundBeam2Phase){
+      AliError("No beam2 LHC clock phase values found within the run!");
+      delete phaseObj;
+      return NULL;
+    }
+  }
+
+  return phaseObj;
+}