coding conventions

diff --git a/STEER/AliQA.cxx b/STEER/AliQA.cxx
index b083ea6d37110a46737e1c69372f9b8f1f249002..3ad2d917638c45c438f2561bca88a8b1f80e520b 100644 (file)
--- a/STEER/AliQA.cxx
+++ b/STEER/AliQA.cxx
@@ -67,18 +67,18 @@ TString    AliQA::fgRTNames[]            = {"UNKNOWN", "AUTO_TEST", "CALIBRATION
                                                                                                                                                                                "STANDALONE_EMD", "STANDALONE_LASER", "STANDALONE_MB", "STANDALONE_PEDESTAL", 
                                                                                                                                                                                "STANDALONE_SEMICENTRAL", "STANDALONE_PULSER" } ;   
 TString       AliQA::fgTaskNames[]       = {"Raws", "Hits", "SDigits", "Digits", "RecPoints", "TrackSegments", "RecParticles", "ESDs"} ;   
-const TString AliQA::fkgLabLocalFile     = "file://"  ; 
-const TString AliQA::fkgLabLocalOCDB     = "local://" ;  
-const TString AliQA::fkgLabAliEnOCDB     = "alien://" ;  
-const TString AliQA::fkgRefFileName      = "QA.root" ; 
-const TString AliQA::fkgQAName           = "QA"  ; 
-const TString AliQA::fkgQACorrNtName     = "CorrQA" ;  
-const TString AliQA::fkgRefOCDBDirName   = "Ref"  ; 
-TString AliQA::fkgRefDataDirName              = ""  ; 
-const TString AliQA::fkgQARefOCDBDefault = "alien://folder=/alice/QA/20"  ; 
-const TString AliQA::fkgExpert           = "Expert" ; 
-const UInt_t  AliQA::fkgExpertBit        = 16 ; 
-const UInt_t  AliQA::fkgQABit            = 17 ; 
+const TString AliQA::fgkLabLocalFile     = "file://"  ; 
+const TString AliQA::fgkLabLocalOCDB     = "local://" ;  
+const TString AliQA::fgkLabAliEnOCDB     = "alien://" ;  
+const TString AliQA::fgkRefFileName      = "QA.root" ; 
+const TString AliQA::fgkQAName           = "QA"  ; 
+const TString AliQA::fgkQACorrNtName     = "CorrQA" ;  
+const TString AliQA::fgkRefOCDBDirName   = "Ref"  ; 
+TString AliQA::fgkRefDataDirName              = ""  ; 
+const TString AliQA::fgkQARefOCDBDefault = "alien://folder=/alice/QA/20"  ; 
+const TString AliQA::fgkExpert           = "Expert" ; 
+const UInt_t  AliQA::fgkExpertBit        = 16 ; 
+const UInt_t  AliQA::fgkQABit            = 17 ; 
 
 //____________________________________________________________________________
 AliQA::AliQA() : 
@@ -356,8 +356,8 @@ TFile * AliQA::GetQAResultFile()
        fgQAResultFile = 0x0 ; 
 //     if (!fgQAResultFile) { 
                TString dirName(fgQAResultDirName) ; 
-               if ( dirName.Contains(fkgLabLocalFile)) 
-                       dirName.ReplaceAll(fkgLabLocalFile, "") ;
+               if ( dirName.Contains(fgkLabLocalFile)) 
+                       dirName.ReplaceAll(fgkLabLocalFile, "") ;
                TString fileName(dirName + fgQAResultFileName) ; 
                TString opt("") ; 
                if ( !gSystem->AccessPathName(fileName) )
@@ -376,6 +376,7 @@ TFile * AliQA::GetQAResultFile()
 //_______________________________________________________________
 const TString AliQA::GetRunTypeName(RUNTYPE_t rt) 
 { 
+  // returns the name of a run type
        TString rv("Invalid Run Type") ;        
        if ( rt == kNULLTYPE ) {
                rv = "Known RUN_TYPE are: \n" ; 
@@ -607,12 +608,12 @@ void AliQA::SetQARefStorage(const char * name)
        // Set the root directory where the QA reference data are stored
 
        fgQARefDirName = name ; 
-       if ( fgQARefDirName.Contains(fkgLabLocalFile) )
-               fgQARefFileName =  fkgRefFileName ; 
-       else if ( fgQARefDirName.Contains(fkgLabLocalOCDB) )
-               fgQARefFileName =  fkgQAName ; 
-       else if ( fgQARefDirName.Contains(fkgLabAliEnOCDB) )
-               fgQARefFileName =  fkgQAName ; 
+       if ( fgQARefDirName.Contains(fgkLabLocalFile) )
+               fgQARefFileName =  fgkRefFileName ; 
+       else if ( fgQARefDirName.Contains(fgkLabLocalOCDB) )
+               fgQARefFileName =  fgkQAName ; 
+       else if ( fgQARefDirName.Contains(fgkLabAliEnOCDB) )
+               fgQARefFileName =  fgkQAName ; 
 
   else {
          printf("ERROR: %s is an invalid storage definition\n", name) ; 
@@ -651,8 +652,8 @@ void AliQA::SetQAResultDirName(const char * name)
 
   fgQAResultDirName.Prepend(name) ; 
   printf("AliQA::SetQAResultDirName: QA results are in  %s\n", fgQAResultDirName.Data()) ;
-  if ( fgQAResultDirName.Contains(fkgLabLocalFile)) 
-    fgQAResultDirName.ReplaceAll(fkgLabLocalFile, "") ;
+  if ( fgQAResultDirName.Contains(fgkLabLocalFile)) 
+    fgQAResultDirName.ReplaceAll(fgkLabLocalFile, "") ;
   fgQAResultFileName.Prepend(fgQAResultDirName) ;
 }
 

diff --git a/STEER/AliQA.h b/STEER/AliQA.h
index c2f2fb8ab785fa2bc9ad17e5f64a514095f063ea..bf632349efdb7bed8dc6f66247c5f59761f520ba 100644 (file)
--- a/STEER/AliQA.h
+++ b/STEER/AliQA.h
@@ -25,12 +25,12 @@ public:
        enum QABIT_t {
     kNULLBit=-1, kINFO, kWARNING, kERROR, kFATAL, kNBIT };
   enum RUNTYPE_t {
-    kNULLTYPE=-1, kUNKOWN, kAUTO_TEST, kCALIBRATION, kCALIBRATION_PULSER, kCHANNEL_DELAY_TUNING, kCOSMIC, kCOSMICS, kDAQ_FO_UNIF_SCAN, 
-    kDAQ_GEN_DAC_SCAN, kDAQ_MEAN_TH_SCAN, kDAQ_MIN_TH_SCAN, kDAQ_NOISY_PIX_SCAN, kDAQ_PIX_DELAY_SCAN, kDAQ_UNIFORMITY_SCAN, 
-    kDCS_FO_UNIF_SCAN, kDCS_MEAN_TH_SCAN, kDCS_MIN_TH_SCAN, kDCS_PIX_DELAY_SCAN, kDCS_UNIFORMITY_SCAN, kDDL_TEST, kGAIN, 
-    kPEDESTAL, kINJECTOR,  kLASER, kMONTECARLO, kNOISE, kNOISY_PIX_SCAN,  kPHYSICS, kPULSER, kSTANDALONE, kSTANDALONE_BC, 
-    kSTANDALONE_CENTRAL, kSTANDALONE_COSMIC, kSTANDALONE_EMD, kSTANDALONE_LASER, kSTANDALONE_MB, kSTANDALONE_PEDESTAL, 
-    kSTANDALONE_SEMICENTRAL, kSTANDALONE_PULSER, kNTYPE};
+    kNULLTYPE=-1, kUNKOWN, kAUTOTEST, kCALIBRATION, kCALIBRATIONPULSER, kCHANNELDELAYTUNING, kCOSMIC, kCOSMICS, kDAQFOUNIFSCAN, 
+    kDAQGENDACSCAN, kDAQMEANTHSCAN, kDAQMINTHSCAN, kDAQNOISYPIXSCAN, kDAQPIXDELAYSCAN, kDAQUNIFORMITYSCAN, 
+    kDCSFOUNIFSCAN, kDCSMEANTHSCAN, kDCSMINTHSCAN, kDCSPIXDELAYSCAN, kDCSUNIFORMITYSCAN, kDDLTEST, kGAIN, 
+    kPEDESTAL, kINJECTOR,  kLASER, kMONTECARLO, kNOISE, kNOISYPIXSCAN,  kPHYSICS, kPULSER, kSTANDALONE, kSTANDALONEBC, 
+    kSTANDALONECENTRAL, kSTANDALONECOSMIC, kSTANDALONEEMD, kSTANDALONELASER, kSTANDALONEMB, kSTANDALONEPEDESTAL, 
+    kSTANDALONESEMICENTRAL, kSTANDALONEPULSER, kNTYPE};
        
        enum TASKINDEX_t {
     kNULLTASKINDEX=-1, kRAWS, kHITS, kSDIGITS, kDIGITS, kRECPOINTS, kTRACKSEGMENTS, kRECPARTICLES, kESDS, kNTASKINDEX };
@@ -50,30 +50,30 @@ public:
   Bool_t                 CheckFatal() const ;
        static void            Close() ; 
        static  char *         GetAliTaskName(ALITASK_t tsk) ;
-  static const TString   GetExpert() { return fkgExpert ; }
-  static  UInt_t         GetExpertBit() { return fkgExpertBit ; }
-       static const TString   GetLabLocalFile() { return fkgLabLocalFile ; } 
-       static const TString   GetLabLocalOCDB() { return fkgLabLocalOCDB ; } 
-       static const TString   GetLabAliEnOCDB() { return fkgLabAliEnOCDB ; } 
+  static const TString   GetExpert() { return fgkExpert ; }
+  static  UInt_t         GetExpertBit() { return fgkExpertBit ; }
+       static const TString   GetLabLocalFile() { return fgkLabLocalFile ; } 
+       static const TString   GetLabLocalOCDB() { return fgkLabLocalOCDB ; } 
+       static const TString   GetLabAliEnOCDB() { return fgkLabAliEnOCDB ; } 
        static  DETECTORINDEX_t GetDetIndex(const char * name) ; 
        static const TString   GetDetName(DETECTORINDEX_t det) { return fgDetNames[det] ; }
        static const char *    GetDetName(Int_t det) ;
        static const TString   GetGRPPath() { return fgGRPPath ; }  
-  static  UInt_t         GetQABit() { return fkgQABit ; }
+  static  UInt_t         GetQABit() { return fgkQABit ; }
        static TFile *         GetQADataFile(const char * name, const Int_t run) ; 
        static TFile *         GetQADataFile(const char * fileName) ;
        static const char *    GetQADataFileName(const char * name, const Int_t run) 
     {return Form("%s.%s.%d.root", name, fgQADataFileName.Data(), run)  ; }
        static const char *    GetQADataFileName() { return fgQADataFileName.Data() ; }
-       static const char *    GetQAName() { return fkgQAName ; } 
-  static const char *    GetQACorrName() { return fkgQACorrNtName ; }
+       static const char *    GetQAName() { return fgkQAName ; } 
+  static const char *    GetQACorrName() { return fgkQACorrNtName ; }
        static TFile *         GetQAResultFile() ; 
        static const char  *   GetQAResultFileName() { return (fgQAResultDirName + fgQAResultFileName).Data() ; }
-       static const char  *   GetQARefDefaultStorage() { return fkgQARefOCDBDefault.Data() ; }
+       static const char  *   GetQARefDefaultStorage() { return fgkQARefOCDBDefault.Data() ; }
        static const char  *   GetQARefFileName() { return fgQARefFileName ; }
        static const char  *   GetQARefStorage() { return fgQARefDirName.Data() ; }
-       static const char  *   GetRefOCDBDirName() { return fkgRefOCDBDirName.Data() ; }
-       static const char  *   GetRefDataDirName() { return fkgRefDataDirName.Data() ; }
+       static const char  *   GetRefOCDBDirName() { return fgkRefOCDBDirName.Data() ; }
+       static const char  *   GetRefDataDirName() { return fgkRefDataDirName.Data() ; }
        static const TString   GetRunTypeName(RUNTYPE_t rt = kNULLTYPE) ;
        static  TASKINDEX_t    GetTaskIndex(const char * name) ; 
        static const TString   GetTaskName(UInt_t tsk) { return fgTaskNames[tsk] ; }
@@ -84,7 +84,7 @@ public:
        void                   Set(QABIT_t bit) ;
        static void                            SetQAResultDirName(const char * name) ; 
        static void            SetQARefStorage(const char * name) ; 
-       static void            SetQARefDataDirName(RUNTYPE_t rt) { fkgRefDataDirName = GetRunTypeName(rt) ; }
+       static void            SetQARefDataDirName(RUNTYPE_t rt) { fgkRefDataDirName = GetRunTypeName(rt) ; }
        static void            SetQARefDataDirName(const char * name) ;
        void                   Show() const { ShowStatus(fDet, fTask) ; }
        void                   Show(DETECTORINDEX_t det) const { ShowStatus(det) ; }
@@ -126,18 +126,18 @@ private:
        static TString       fgQAResultFileName     ; //! the output file where the QA results are stored  
        static TString       fgRTNames[]                  ; //! list of Run Type names   
        static TString       fgTaskNames[]              ; //! list of tasks names   
-  static const TString fkgExpert              ; //! name for the expert directory
-  static const UInt_t  fkgExpertBit           ; //! TObject bit identifing the object as "expert"
-       static const TString fkgLabLocalFile        ; //! label to identify a file as local 
-       static const TString fkgLabLocalOCDB        ; //! label to identify a file as local OCDB 
-       static const TString fkgLabAliEnOCDB        ; //! label to identify a file as AliEn OCDB 
-       static const TString fkgRefFileName         ; //! name of Reference File Name 
-       static const UInt_t  fkgQABit               ; //! bit in the QA data object which is set when Checker does not return 0
-       static const TString fkgQAName              ; //! name of QA object 
-       static const TString fkgQACorrNtName        ; //! name of QA Correlation Ntuple
-       static const TString fkgRefOCDBDirName      ; //! name of Reference directory name in OCDB      
-       static       TString fkgRefDataDirName      ; //! name of Reference directory name in OCDB for data     
-       static const TString fkgQARefOCDBDefault    ; //! default storage for QA in OCDB 
+  static const TString fgkExpert              ; //! name for the expert directory
+  static const UInt_t  fgkExpertBit           ; //! TObject bit identifing the object as "expert"
+       static const TString fgkLabLocalFile        ; //! label to identify a file as local 
+       static const TString fgkLabLocalOCDB        ; //! label to identify a file as local OCDB 
+       static const TString fgkLabAliEnOCDB        ; //! label to identify a file as AliEn OCDB 
+       static const TString fgkRefFileName         ; //! name of Reference File Name 
+       static const UInt_t  fgkQABit               ; //! bit in the QA data object which is set when Checker does not return 0
+       static const TString fgkQAName              ; //! name of QA object 
+       static const TString fgkQACorrNtName        ; //! name of QA Correlation Ntuple
+       static const TString fgkRefOCDBDirName      ; //! name of Reference directory name in OCDB      
+       static       TString fgkRefDataDirName      ; //! name of Reference directory name in OCDB for data     
+       static const TString fgkQARefOCDBDefault    ; //! default storage for QA in OCDB 
   
   ClassDef(AliQA,1)  //ALICE Quality Assurance Object
 };