F. coverity

AliESDCosmic.cxx  - pointer check
AliTPCClusterParam.cxx - snprintf
AliTPCMonitor.cxx - pointer check
AliTPCFast.cxx   - pointer check
AliTPCTempMap.cxx - memory leak
AliTPCkalmanFit.cxx - memory leak

diff --git a/TPC/AliESDcosmic.cxx b/TPC/AliESDcosmic.cxx
index 19b475418a5ea066a9a327c102ed8f617b3ba547..2487b3bd5dd1c374c280cd9fc89bbcb6afd949b0 100644 (file)
--- a/TPC/AliESDcosmic.cxx
+++ b/TPC/AliESDcosmic.cxx
@@ -151,8 +151,9 @@ void AliESDcosmic::DumpToTree(){
   TTreeSRedirector * cstream = fDebugStreamer;
   if (!cstream) return;
   if (!fESD) return;
+  if (!fTracksAcorde) return;
   Int_t ntracks0 =fESD->GetNumberOfTracks(); 
-  Int_t ntracks  = (fTracksAcorde) ? fTracksAcorde->GetEntries():0;
+  Int_t ntracks  = fTracksAcorde->GetEntries();
   Float_t mag = fESD->GetMagneticField();
   Int_t   run = fESD->GetRunNumber();
   Int_t   event = fESD->GetEventNumberInFile();

diff --git a/TPC/AliTPCClusterParam.cxx b/TPC/AliTPCClusterParam.cxx
index 7713de1692b39d160e430dbab9986a09750dc6c0..9d023b70934801e7f662b5f5980970150e6c5b8b 100644 (file)
--- a/TPC/AliTPCClusterParam.cxx
+++ b/TPC/AliTPCClusterParam.cxx
@@ -164,6 +164,7 @@ AliTPCClusterParam::AliTPCClusterParam():
   //
   fPosYcor[0]   = 0;   fPosYcor[1]   = 0;   fPosYcor[2]   = 0; 
   fPosZcor[0]   = 0;   fPosZcor[1]   = 0;   fPosZcor[2]   = 0; 
+  fErrorRMSSys[0]=0;   fErrorRMSSys[1]=0; 
 }
 
 AliTPCClusterParam::AliTPCClusterParam(const AliTPCClusterParam& param):
@@ -1159,7 +1160,7 @@ void AliTPCClusterParam::Test(TTree * tree, const char *output){
       snprintf(hcut1,300,"Dim==%d&&QMean<0&&Pad==%d",idim,ipad);
       snprintf(hexp1,300,"(Resol-AliTPCClusterParam::SGetError0(Dim,Pad,Zm,AngleM))/Resol>>%s",hname1);
       TH1F  his1DRel0(hname1, hname1, 100,-0.2, 0.2);
-      snprintf(hname1,1000,"Dim==%d&&QMean<0&&Pad=%d",idim,ipad);
+      snprintf(hname1,300,"Dim==%d&&QMean<0&&Pad=%d",idim,ipad);
       tree->Draw(hexp1,hcut1,"");
       his1DRel0.Write();
       //

diff --git a/TPC/AliTPCFast.cxx b/TPC/AliTPCFast.cxx
index 2d5ec7aa0f3f1ded748bd3a4e5968b00f1802564..039d0bbc7638b110c16eb401ff409a13c70c3a54 100644 (file)
--- a/TPC/AliTPCFast.cxx
+++ b/TPC/AliTPCFast.cxx
@@ -130,9 +130,10 @@ void AliTPCFast::Hits2Clusters(AliRunLoader* runLoader) const
   //---------------------------------------------------------------
   
   TTree *tH = loader->TreeH();
-  if (tH == 0x0)
+  if (tH == 0x0){
     AliFatal("Can not find TreeH in folder");
-
+    return;
+  }
   tpc->SetTreeAddress();
   
   Stat_t ntracks = tH->GetEntries();
@@ -389,9 +390,10 @@ void AliTPCFast::Hits2ExactClustersSector(AliRunLoader* runLoader,
   //---------------------------------------------------------------
   
   TTree *tH = loader->TreeH();
-  if (tH == 0x0)
+  if (tH == 0x0){
     AliFatal("Can not find TreeH in folder");
-
+    return;
+  }
   tpc->SetTreeAddress();
 
   Stat_t ntracks = tH->GetEntries();

diff --git a/TPC/AliTPCMonitor.cxx b/TPC/AliTPCMonitor.cxx
index 0265f5d104840d9b88e5837726e1cb248b462871..f84761a077689ac47b62bf401e6563333706235c 100755 (executable)
--- a/TPC/AliTPCMonitor.cxx
+++ b/TPC/AliTPCMonitor.cxx
@@ -2071,8 +2071,8 @@ Int_t AliTPCMonitor::ExecProcess()
   if(event != 61)  return -1;
   
   TObject *select = gPad->GetSelected();
-  TString name=select->GetName();
   if(!select)  return -1;
+  TString name=select->GetName();
   if(!select->InheritsFrom("TH2")) {gPad->SetUniqueID(0);    return -1;  }
   if(       name=="hglobal"  || name=="SIDE A"  ) side = 0;
   else  if( name=="hglobal2" || name=="SIDE C"  ) side = 1;

diff --git a/TPC/AliTPCTempMap.cxx b/TPC/AliTPCTempMap.cxx
index 67108ab8a313ddffa1a6f1d1f4268fd0b0c73d35..1ae0c9d749ea12f7b4c0c0c39bbdf954cbcc4798 100644 (file)
--- a/TPC/AliTPCTempMap.cxx
+++ b/TPC/AliTPCTempMap.cxx
@@ -167,7 +167,7 @@ TLinearFitter *AliTPCTempMap::GetLinearFitter(Int_t type, Int_t side, UInt_t tim
   // 
 
   TLinearFitter *fitter = new TLinearFitter(3);
-  Double_t *x = new Double_t[3];
+  Double_t x[3]={0};
   Double_t y = 0;
   const Float_t kMaxDelta=0.5;
   
@@ -426,8 +426,8 @@ Double_t AliTPCTempMap::GetTemperature(Double_t x, Double_t y, Double_t z, UInt_
   //
   
   TVectorD paramA(3), paramC(3);
-  TLinearFitter *fitterA = new TLinearFitter(3);
-  TLinearFitter *fitterC = new TLinearFitter(3);
+  TLinearFitter *fitterA = 0;
+  TLinearFitter *fitterC = 0;
 
   fitterA = GetLinearFitter(3, 0, timeSec);
   fitterA->GetParameters(paramA);
@@ -440,8 +440,8 @@ Double_t AliTPCTempMap::GetTemperature(Double_t x, Double_t y, Double_t z, UInt_
   Double_t k = (fvalA-fvalC)/(2*247);
   Double_t tempValue = fvalC+(fvalA-fvalC)/2+k*z;
 
-  fitterA->~TLinearFitter();
-  fitterC->~TLinearFitter();
+  delete fitterA;
+  delete fitterC;
 
   return tempValue;
 

diff --git a/TPC/AliTPCkalmanFit.cxx b/TPC/AliTPCkalmanFit.cxx
index 3e88968c9b00f8a12f8502e224b4c6a4c9377739..5e2f5e49c963513f8872da81f80c7f99504b3642 100644 (file)
--- a/TPC/AliTPCkalmanFit.cxx
+++ b/TPC/AliTPCkalmanFit.cxx
@@ -605,7 +605,7 @@ void AliTPCkalmanFit::AddCovariance(const char * varName, Double_t sigma){
   //
   //
   //
-  if (fCalibCovar) return;
+  if (!fCalibCovar) return;
   if (!fCalibration) return;
   if (!fCalibration->FindObject(varName)) return;
   Int_t ncalibs = fCalibration->GetEntries();
@@ -1319,5 +1319,10 @@ void AliTPCkalmanFit::MakeTreeTrans(TTreeSRedirector *debug, const char *treeNam
     }
     Printf("x0=%f finished",x[0]);
   }
-  
+  delete [] adx;//    = new Double_t[ncalibs];
+  delete [] ady;//    = new Double_t[ncalibs];
+  delete [] adz;//    = new Double_t[ncalibs];
+  delete [] adr;//    = new Double_t[ncalibs];
+  delete [] adrphi;// = new Double_t[ncalibs];
+
 }