fix coverity

diff --git a/PWG1/TRD/AliTRDcalibration.cxx b/PWG1/TRD/AliTRDcalibration.cxx
index 86a475d161c4f841fdc48d28f1ea378395c2ed64..aa5cafc572f41f329bdb0b30aea4e60d7191be6a 100644 (file)
--- a/PWG1/TRD/AliTRDcalibration.cxx
+++ b/PWG1/TRD/AliTRDcalibration.cxx
@@ -1069,8 +1069,10 @@ Bool_t AliTRDcalibration::FillGraphIndex(const TObjArray *vectora,TGraph *graph)
     y[k]  = ((Float_t *)((AliTRDCalibraFit::AliTRDFitInfo *) vectora->At(k))->GetCoef())[0];
   }
 
-  if(!graph) graph = new TGraph(540,&x[0],&y[0]);
-  else{ 
+  if(!graph){
+    graph = new TGraph(540,&x[0],&y[0]);
+    graph->SetMarkerStyle(20);
+  } else{ 
     graph->~TGraph();
     new(graph) TGraph(540,&x[0],&y[0]);
   }

diff --git a/PWG1/TRD/AliTRDcheckDET.cxx b/PWG1/TRD/AliTRDcheckDET.cxx
index ca8d8573158b27362ae1e84c0a68d01e3357d31d..7439883c02c33b353bb28072c5c65acd8f64ed60 100644 (file)
--- a/PWG1/TRD/AliTRDcheckDET.cxx
+++ b/PWG1/TRD/AliTRDcheckDET.cxx
@@ -133,10 +133,10 @@ void AliTRDcheckDET::UserExec(Option_t *opt){
 
   AliTRDrecoTask::UserExec(opt);  
 
-  Int_t nTracks = 0;           // Count the number of tracks per event
+  TH1F *histo(NULL); AliTRDtrackInfo *fTrackInfo(NULL); Int_t nTracks(0);              // Count the number of tracks per event
   for(Int_t iti = 0; iti < fTracks->GetEntriesFast(); iti++){
     if(!fTracks->UncheckedAt(iti)) continue;
-    AliTRDtrackInfo *fTrackInfo = dynamic_cast<AliTRDtrackInfo *>(fTracks->UncheckedAt(iti));
+    if(!(fTrackInfo = dynamic_cast<AliTRDtrackInfo *>(fTracks->UncheckedAt(iti)))) continue;
     if(!fTrackInfo->GetTrack()) continue;
     nTracks++;
   }
@@ -147,17 +147,18 @@ void AliTRDcheckDET::UserExec(Option_t *opt){
   Int_t triggermask = fEventInfo->GetEventHeader()->GetTriggerMask();
   TString triggername =  fEventInfo->GetRunInfo()->GetFiredTriggerClasses(triggermask);
   AliDebug(6, Form("Trigger cluster: %d, Trigger class: %s\n", triggermask, triggername.Data()));
-  dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTrigger))->Fill(triggermask);
+  if((histo = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTrigger)))) histo->Fill(triggermask);
 
-  if(nTracks)
-    dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTriggerTracks))->Fill(triggermask);
+  if(nTracks){
+    if((histo = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTriggerTracks)))) histo->Fill(triggermask);
+  }
   if(triggermask <= 20 && !fTriggerNames->FindObject(Form("%d", triggermask))){
     fTriggerNames->Add(new TObjString(Form("%d", triggermask)), new TObjString(triggername));
     // also set the label for both histograms
-    TH1 *histo = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTriggerTracks));
-    histo->GetXaxis()->SetBinLabel(histo->FindBin(triggermask), triggername);
-    histo = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTrigger));
-    histo->GetXaxis()->SetBinLabel(histo->FindBin(triggermask), triggername);
+    if((histo = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTriggerTracks))))
+      histo->GetXaxis()->SetBinLabel(histo->FindBin(triggermask), triggername);
+    if((histo = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kNeventsTrigger))))
+      histo->GetXaxis()->SetBinLabel(histo->FindBin(triggermask), triggername);
   }
 }
 
@@ -168,53 +169,57 @@ Bool_t AliTRDcheckDET::PostProcess(){
   // Do Postprocessing (for the moment set the number of Reference histograms)
   //
   
-  TH1 * h = NULL;
-  
+  TH1F *h(NULL), *h1(NULL);
+
   // Calculate of the trigger clusters purity
-  h = dynamic_cast<TH1F *>(fContainer->FindObject("hEventsTrigger"));
-  TH1F *h1 = dynamic_cast<TH1F *>(fContainer->FindObject("hEventsTriggerTracks"));
-  h1->Divide(h);
-  Float_t purities[20], val = 0;
-  TString triggernames[20];
-  Int_t nTriggerClasses = 0;
-  for(Int_t ibin = 1; ibin <= h->GetNbinsX(); ibin++){
-    if((val = h1->GetBinContent(ibin))){
-      purities[nTriggerClasses] = val;
-      triggernames[nTriggerClasses] = h1->GetXaxis()->GetBinLabel(ibin);
-      nTriggerClasses++;
+  if((h  = dynamic_cast<TH1F *>(fContainer->FindObject("hEventsTrigger"))) &&
+     (h1 = dynamic_cast<TH1F *>(fContainer->FindObject("hEventsTriggerTracks")))) {
+    h1->Divide(h);
+    Float_t purities[20], val = 0; memset(purities, 0, 20*sizeof(Float_t));
+    TString triggernames[20];
+    Int_t nTriggerClasses = 0;
+    for(Int_t ibin = 1; ibin <= h->GetNbinsX(); ibin++){
+      if((val = h1->GetBinContent(ibin))){
+        purities[nTriggerClasses] = val;
+        triggernames[nTriggerClasses] = h1->GetXaxis()->GetBinLabel(ibin);
+        nTriggerClasses++;
+      }
+    }
+
+    if((h = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kTriggerPurity)))){
+      TAxis *ax = h->GetXaxis();
+      for(Int_t itrg = 0; itrg < nTriggerClasses; itrg++){
+        h->Fill(itrg, purities[itrg]);
+        ax->SetBinLabel(itrg+1, triggernames[itrg].Data());
+      }
+      ax->SetRangeUser(-0.5, nTriggerClasses+.5);
+      h->GetYaxis()->SetRangeUser(0,1);
     }
   }
-  h = dynamic_cast<TH1F *>(fContainer->UncheckedAt(kTriggerPurity));
-  TAxis *ax = h->GetXaxis();
-  for(Int_t itrg = 0; itrg < nTriggerClasses; itrg++){
-    h->Fill(itrg, purities[itrg]);
-    ax->SetBinLabel(itrg+1, triggernames[itrg].Data());
-  }
-  ax->SetRangeUser(-0.5, nTriggerClasses+.5);
-  h->GetYaxis()->SetRangeUser(0,1);
 
   // track status
-  h=dynamic_cast<TH1F*>(fContainer->At(kTrackStatus));
-  Float_t ok = h->GetBinContent(1);
-  Int_t nerr = h->GetNbinsX();
-  for(Int_t ierr=nerr; ierr--;){
-    h->SetBinContent(ierr+1, ok>0.?1.e2*h->GetBinContent(ierr+1)/ok:0.);
+  if((h=dynamic_cast<TH1F*>(fContainer->At(kTrackStatus)))){
+    Float_t ok = h->GetBinContent(1);
+    Int_t nerr = h->GetNbinsX();
+    for(Int_t ierr=nerr; ierr--;){
+      h->SetBinContent(ierr+1, ok>0.?1.e2*h->GetBinContent(ierr+1)/ok:0.);
+    }
+    h->SetBinContent(1, 0.);
   }
-  h->SetBinContent(1, 0.);
-
   // tracklet status
   
-  TObjArray *arr = dynamic_cast<TObjArray*>(fContainer->UncheckedAt(kTrackletStatus));
-  for(Int_t ily = AliTRDgeometry::kNlayer; ily--;){
-    h=dynamic_cast<TH1F*>(arr->At(ily));
-    Float_t okB = h->GetBinContent(1);
-    Int_t nerrB = h->GetNbinsX();
-    for(Int_t ierr=nerrB; ierr--;){
-      h->SetBinContent(ierr+1, okB>0.?1.e2*h->GetBinContent(ierr+1)/okB:0.);
+  TObjArray *arr(NULL);
+  if(( arr = dynamic_cast<TObjArray*>(fContainer->UncheckedAt(kTrackletStatus)))){
+    for(Int_t ily = AliTRDgeometry::kNlayer; ily--;){
+      if(!(h=dynamic_cast<TH1F*>(arr->At(ily)))) continue;
+      Float_t okB = h->GetBinContent(1);
+      Int_t nerrB = h->GetNbinsX();
+      for(Int_t ierr=nerrB; ierr--;){
+        h->SetBinContent(ierr+1, okB>0.?1.e2*h->GetBinContent(ierr+1)/okB:0.);
+      }
+      h->SetBinContent(1, 0.);
     }
-    h->SetBinContent(1, 0.);
   }
-
   fNRefFigures = 17;
 
   return kTRUE;
@@ -340,7 +345,6 @@ Bool_t AliTRDcheckDET::GetRefFigure(Int_t ifig){
     gPad->SetLogy(0);
     return kTRUE;
   case kFigChi2:
-    return kTRUE;
     MakePlotChi2();
     return kTRUE;
   case kFigPH:
@@ -1025,7 +1029,7 @@ TH1 *AliTRDcheckDET::PlotPHt(const AliTRDtrackV1 *track){
         Float_t theta = TMath::ATan(tracklet->GetZref(1));
         Float_t phi = TMath::ATan(tracklet->GetYref(1));
         AliExternalTrackParam *trdPar = fkTrack->GetTrackIn();
-        Float_t momentumMC = 0, momentumRec = trdPar ? trdPar->P() : track->P(); // prefer Track Low
+        Float_t momentumMC = 0, momentumRec = trdPar ? trdPar->P() : fkTrack->P(); // prefer Track Low
         Int_t pdg = 0;
         Int_t kinkIndex = fkESD ? fkESD->GetKinkIndex() : 0;
         UShort_t tpcNCLS = fkESD ? fkESD->GetTPCncls() : 0;
@@ -1258,7 +1262,7 @@ TH1* AliTRDcheckDET::MakePlotChi2()
 
   return NULL;
 
-  TH2S *h2 = (TH2S*)fContainer->At(kChi2);
+/*  TH2S *h2 = (TH2S*)fContainer->At(kChi2);
   TF1 f("fChi2", "[0]*pow(x, [1]-1)*exp(-0.5*x)", 0., 50.);
   f.SetParLimits(1,1, 1e100);
   TLegend *leg = new TLegend(.7,.7,.95,.95);
@@ -1281,7 +1285,7 @@ TH1* AliTRDcheckDET::MakePlotChi2()
   }
   leg->Draw();
   gPad->SetLogy();
-  return h1;
+  return h1;*/
 }
 
 
@@ -1470,7 +1474,7 @@ void AliTRDcheckDET::MakePlotMeanClustersLayer(){
   }
   TProfile2D *hlayer = NULL;
   for(Int_t ily = 0; ily < AliTRDgeometry::kNlayer; ily++){
-    hlayer = dynamic_cast<TProfile2D *>(histos->At(ily));
+    if(!(hlayer = dynamic_cast<TProfile2D *>(histos->At(ily)))) continue;
     output->cd(ily + 1);
     gPad->SetGrid(0,0);
     hlayer->Draw("colz");

diff --git a/PWG1/TRD/AliTRDcheckESD.cxx b/PWG1/TRD/AliTRDcheckESD.cxx
index 2f47c744400177aad2831eb8eefc04dfea788f2a..d39fd9a1ac207c5a97d5ae0718a04a63859ed274 100644 (file)
--- a/PWG1/TRD/AliTRDcheckESD.cxx
+++ b/PWG1/TRD/AliTRDcheckESD.cxx
@@ -450,7 +450,7 @@ Bool_t AliTRDcheckESD::GetRefFigure(Int_t ifig)
     pad->SetLeftMargin(0.15); pad->SetRightMargin(0.1);
     pad->SetTopMargin(0.1); pad->SetBottomMargin(0.15);
     pad->SetGridx(kFALSE); pad->SetGridy(kFALSE);
-    hProf2D = dynamic_cast<TProfile2D*>(fHistos->At(kTRDEtaPhiAvNtrkl));
+    if(!(hProf2D = dynamic_cast<TProfile2D*>(fHistos->At(kTRDEtaPhiAvNtrkl)))) break;
     hProf2D->SetStats(kFALSE);
     hProf2D->SetTitle("");
     hProf2D->GetXaxis()->SetTitle("#eta");
@@ -517,7 +517,7 @@ Bool_t AliTRDcheckESD::GetRefFigure(Int_t ifig)
     pad->SetTopMargin(0.02); pad->SetBottomMargin(0.15);
     pad->SetGridx(kFALSE); pad->SetGridy(kFALSE);
     pad->SetLogz();
-    h2F = dynamic_cast<TH2F*>(fHistos->At(kNClsTrackTRD));
+    if(!(h2F = dynamic_cast<TH2F*>(fHistos->At(kNClsTrackTRD)))) break;
     h2F->SetStats(kFALSE);
     h2F->SetTitle("");
     h2F->GetXaxis()->SetTitle("p [GeV/c]");
@@ -999,7 +999,7 @@ void AliTRDcheckESD::UserExec(Option_t *){
       AliTrackReference *ref(NULL); 
       Int_t fLabel(esdTrack->GetLabel());
       Int_t fIdx(TMath::Abs(fLabel));
-      if(fIdx > fStack->GetNtrack()) continue; 
+      if(!fStack || fIdx > fStack->GetNtrack()) continue; 
       
       // read MC particle 
       if(!(mcParticle = (AliMCParticle*) fMC->GetTrack(fIdx))) {

diff --git a/PWG1/TRD/AliTRDcheckPID.cxx b/PWG1/TRD/AliTRDcheckPID.cxx
index 7194d97cb2725e2c085f5c37ab7ec88b91d38e1e..aeba1a7f069a8325ed64fd509e3f59886ab6eddd 100644 (file)
--- a/PWG1/TRD/AliTRDcheckPID.cxx
+++ b/PWG1/TRD/AliTRDcheckPID.cxx
@@ -846,9 +846,10 @@ TH1 *AliTRDcheckPID::PlotV0(const AliTRDtrackV1 *track)
     AliWarning("No output container defined.");
     return NULL;
   }
-  AliDebug(2, Form("TRACK[%d] species[%s][%d]\n", fkESD->GetId(), AliPID::ParticleShortName(fkMC->GetPID()), fkMC->GetPDG()));
+  AliDebug(2, Form("TRACK[%d] species[%s][%d]\n", fkESD->GetId(), fkMC->GetPID()>=0?AliPID::ParticleShortName(fkMC->GetPID()):"none", fkMC->GetPDG()));
 
-  TH1 *h=dynamic_cast<TH1F*>(fContainer->At(kV0));
+  TH1 *h(NULL);
+  if(!(h = dynamic_cast<TH1F*>(fContainer->At(kV0)))) return NULL;
   Int_t sgn(0), n(0); AliTRDv0Info *v0(NULL);
   for(Int_t iv0(fV0s->GetEntriesFast()); iv0--;){
     if(!(v0=(AliTRDv0Info*)fV0s->At(iv0))) continue;
@@ -1066,7 +1067,7 @@ Bool_t AliTRDcheckPID::GetRefFigure(Int_t ifig)
         h1->GetXaxis()->SetTitle("x_{drift} [cm]");
         h1->GetYaxis()->SetTitle("<dQ/dl> [a.u./cm]");
       }
-      h = (TH1F*)h1->DrawClone(kFIRST ? "c" : "samec");
+      h1->DrawClone(kFIRST ? "c" : "samec");
       kFIRST = kFALSE;
     }
 

diff --git a/PWG1/TRD/AliTRDclusterResolution.cxx b/PWG1/TRD/AliTRDclusterResolution.cxx
index 26f685e5866753ff41430d85b9b60e803c6af9c1..fae67c35be9bd75784166e485e13c46467c37b0a 100644 (file)
--- a/PWG1/TRD/AliTRDclusterResolution.cxx
+++ b/PWG1/TRD/AliTRDclusterResolution.cxx
@@ -579,7 +579,10 @@ void AliTRDclusterResolution::UserExec(Option_t *)
     fContainer = Histos();
     PostData(1, fContainer);
   }
-  fInfo = dynamic_cast<TObjArray *>(GetInputData(1));
+  if(!(fInfo = dynamic_cast<TObjArray *>(GetInputData(1)))){
+    AliError("Cluster array missing.");
+    return;
+  }
   AliDebug(2, Form("Clusters[%d]", fInfo->GetEntriesFast()));
 
   Int_t det, t, np;

diff --git a/PWG1/TRD/AliTRDefficiency.cxx b/PWG1/TRD/AliTRDefficiency.cxx
index 15e282aa33acb7cc02137067d2bf96b98479634a..0194ddc8ef5f351d87cd940d99a4d1e33cb29423 100644 (file)
--- a/PWG1/TRD/AliTRDefficiency.cxx
+++ b/PWG1/TRD/AliTRDefficiency.cxx
@@ -323,7 +323,7 @@ Bool_t AliTRDefficiency::GetRefFigure(Int_t ifig)
       }
       bFIRST = kFALSE;
     }
-    leg->Draw();
+    if(leg) leg->Draw();
     break;
   }
   return kTRUE;

diff --git a/PWG1/TRD/AliTRDefficiencyMC.cxx b/PWG1/TRD/AliTRDefficiencyMC.cxx
index 0b74913ab960bb970ab5da14ae8b413ca707a87c..6d23731b46bf61a2ca6daae8f050aa621924f600 100644 (file)
--- a/PWG1/TRD/AliTRDefficiencyMC.cxx
+++ b/PWG1/TRD/AliTRDefficiencyMC.cxx
@@ -117,7 +117,7 @@ void AliTRDefficiencyMC::UserExec(Option_t *){
   Int_t nTrackInfos = fTracks->GetEntriesFast();
   AliDebug(2, Form("   CANDIDATE TRACKS[%d]", nTrackInfos));
 
-  AliTRDtrackV1 *trackTRD(NULL);
+  //AliTRDtrackV1 *trackTRD(NULL);
   AliTRDtrackInfo *trkInf(NULL);
   for(Int_t itinf = 0; itinf < nTrackInfos; itinf++){
     trkInf = dynamic_cast<AliTRDtrackInfo *>(fTracks->UncheckedAt(itinf));
@@ -130,7 +130,7 @@ void AliTRDefficiencyMC::UserExec(Option_t *){
         AliDebug(2, Form("MC(Track Reference) missing @ label[%d]", trkInf->GetLabel()));
         isContamination = kTRUE;
         // Debugging
-        if(trackTRD && DebugLevel()>5) FillStreamTrackWOMC(trkInf);
+        if(trkInf && DebugLevel()>5) FillStreamTrackWOMC(trkInf);
       }
       if(isContamination){
         // reject kink (we count these only once)
@@ -177,7 +177,7 @@ void AliTRDefficiencyMC::UserExec(Option_t *){
   memcpy(tmprejected, indexReject, sizeof(Int_t) * nreject);
   nreject = 0;
   for(Int_t irej = 0; irej < nrej; irej++){
-    trkInf = dynamic_cast<AliTRDtrackInfo *>(fTracks->At(tmprejected[irej]));
+    if(!(trkInf = dynamic_cast<AliTRDtrackInfo *>(fTracks->At(tmprejected[irej])))) continue;
     Int_t idx(-1);
     if((idx = IsRegistered(trkInf,indexAccept,naccept))<0){
       indexReject[nreject++] = tmprejected[irej];
@@ -222,61 +222,62 @@ Bool_t AliTRDefficiencyMC::GetRefFigure(Int_t ifig){
   if(ifig >= fNRefFigures) return kFALSE;
   if(!gPad) return kFALSE;
   gPad->SetLogx(kTRUE);
+  TH1 *h(NULL);
   if(ifig < 2){
-    (dynamic_cast<TH1 *>(fContainer->At(ifig)))->Draw("e1");
+    if(!(h = (dynamic_cast<TH1 *>(fContainer->At(ifig))))) return kFALSE;
+    h->Draw("e1");
     return kTRUE;
   }
-  TH1 *h(NULL); 
   TLegend *leg=new TLegend(.65, .12, .85, .3);
   leg->SetHeader("Charge");
   leg->SetBorderSize(1);leg->SetFillColor(kWhite);
   switch(ifig){
   case 2:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+1));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+1)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
   case 3:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+2));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+2)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+3));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+3)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
   case 4:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+4));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+4)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+5));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+5)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
   case 5:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+6));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+6)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+7));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+7)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
   case 6:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+8));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+8)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+9));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+9)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
   case 7:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+10));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+10)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+11));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+11)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
   case 8:
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+12));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+12)))) return kFALSE;;
     h->Draw("e1"); leg->AddEntry(h, "  -", "pl");
-    h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+13));
+    if(!(h=dynamic_cast<TH1 *>(fContainer->At(kEfficiencySpeciesHistogram+13)))) return kFALSE;;
     h->Draw("e1same"); leg->AddEntry(h, "  +", "pl");
     leg->Draw();
     break;
@@ -446,7 +447,7 @@ void AliTRDefficiencyMC::FillHistograms(Int_t nTracks, Int_t *indices, ETRDeffic
   Int_t trkpdg(-1);      // particle PDG code
   AliTRDtrackInfo *trkInf(NULL);
   for(Int_t itk = 0; itk < nTracks; itk++){
-    trkInf = dynamic_cast<AliTRDtrackInfo *>(fTracks->At(indices[itk]));
+    if(!(trkInf = dynamic_cast<AliTRDtrackInfo *>(fTracks->At(indices[itk])))) continue;
     if(trkInf->GetNTrackRefs()){
       // use Monte-Carlo Information for Momentum and PID
       trkmom = trkInf->GetTrackRef(0)->P();
@@ -456,20 +457,26 @@ void AliTRDefficiencyMC::FillHistograms(Int_t nTracks, Int_t *indices, ETRDeffic
       trkmom = trkInf->GetTrack()->P();
     }
 
+    TProfile *hp(NULL);
     const Char_t *cmode(NULL);
     switch(mode){
       case kAccept:
-        (dynamic_cast<TProfile *>(fContainer->At(kEfficiencyHistogram)))->Fill(trkmom, 1);
-        (dynamic_cast<TProfile *>(fContainer->At(kContaminationHistogram)))->Fill(trkmom, 0);
+        if(!(hp = (dynamic_cast<TProfile *>(fContainer->At(kEfficiencyHistogram))))) continue;
+        hp->Fill(trkmom, 1);
+        if(!(hp = ((dynamic_cast<TProfile *>(fContainer->At(kContaminationHistogram)))))) continue;
+        hp->Fill(trkmom, 0);
         cmode="ACCEPT";
         break;
       case kMiss:
-        (dynamic_cast<TProfile *>(fContainer->At(kEfficiencyHistogram)))->Fill(trkmom, 0);
-        (dynamic_cast<TProfile *>(fContainer->At(kContaminationHistogram)))->Fill(trkmom, 0);
+        if(!(hp = ((dynamic_cast<TProfile *>(fContainer->At(kEfficiencyHistogram)))))) continue;
+        hp->Fill(trkmom, 0);
+        if(!(hp = ((dynamic_cast<TProfile *>(fContainer->At(kContaminationHistogram)))))) continue;
+        hp->Fill(trkmom, 0);
         cmode="MISS";
         break;
       case kFake:
-        (dynamic_cast<TProfile *>(fContainer->At(kContaminationHistogram)))->Fill(trkmom, 1);
+        if(!(hp = ((dynamic_cast<TProfile *>(fContainer->At(kContaminationHistogram)))))) continue;
+        hp->Fill(trkmom, 1);
         cmode="FAKE";
         break;
     }
@@ -480,7 +487,8 @@ void AliTRDefficiencyMC::FillHistograms(Int_t nTracks, Int_t *indices, ETRDeffic
     Int_t sign = dbPDG->GetParticle(trkpdg)->Charge() > 0. ? 1 : 0;
     //printf("[%d]%s pdg[%d] sign[%d]\n", idxSpec, AliPID::ParticleName(idxSpec), trkpdg, sign);
     if(idxSpec < 0) idxSpec = AliPID::kSPECIES;
-    (dynamic_cast<TProfile *>(fContainer->At(kEfficiencySpeciesHistogram + idxSpec*2+sign)))->Fill(trkmom, mode==kAccept?1:0);
+    if(!(hp = (dynamic_cast<TProfile *>(fContainer->At(kEfficiencySpeciesHistogram + idxSpec*2+sign))))) continue;
+    hp->Fill(trkmom, mode==kAccept?1:0);
   }
 }
 
@@ -567,9 +575,11 @@ Int_t AliTRDefficiencyMC::IsRegistered(const AliTRDtrackInfo * const trkInf, Int
   // Checks if track is registered in a given mode
   //
 
+  AliTRDtrackInfo *ti(NULL);
   Int_t label(trkInf->GetLabel());
   for(Int_t il(nTracks); il--;){
-    if((dynamic_cast<AliTRDtrackInfo *>(fTracks->At(indices[il])))->GetLabel() == label) return il;
+    if(!(ti = dynamic_cast<AliTRDtrackInfo *>(fTracks->At(indices[il])))) continue;
+    if(ti->GetLabel() == label) return il;
   }
   return -1;
 }

diff --git a/PWG1/TRD/AliTRDinfoGen.cxx b/PWG1/TRD/AliTRDinfoGen.cxx
index 18ca59c013bf0893ba128e321f0f2c8cd9bad211..bd05bb24f95ea72bde9aa4a8eeb246d54011004f 100644 (file)
--- a/PWG1/TRD/AliTRDinfoGen.cxx
+++ b/PWG1/TRD/AliTRDinfoGen.cxx
@@ -300,15 +300,19 @@ void AliTRDinfoGen::UserExec(Option_t *){
     ocdb->SetDefaultStorage(fOCDB.Data());
     ocdb->SetRun(fESDev->GetRunNumber());
     // create geo manager
-    AliCDBEntry* obj = ocdb->Get(AliCDBPath("GRP", "Geometry", "Data"));
-    AliGeomManager::SetGeometry((TGeoManager*)obj->GetObject());
-    AliGeomManager::GetNalignable("TRD");
-    AliGeomManager::ApplyAlignObjsFromCDB("TRD");
+    AliCDBEntry* obj(NULL);
+    if(!(obj = ocdb->Get(AliCDBPath("GRP", "Geometry", "Data")))){
+      AliError("GEOMETRY failed initialization.");
+    } else {
+      AliGeomManager::SetGeometry((TGeoManager*)obj->GetObject());
+      AliGeomManager::GetNalignable("TRD");
+      AliGeomManager::ApplyAlignObjsFromCDB("TRD");
+    }
     fgGeo = new AliTRDgeometry;
     //init magnetic field
     if(!TGeoGlobalMagField::Instance()->IsLocked() &&
        !fESDev->InitMagneticField()){
-      AliWarning("Magnetic field failed initialization.");
+      AliError("MAGNETIC FIELD failed initialization.");
     }
 
     // set no of time bins
@@ -319,22 +323,26 @@ void AliTRDinfoGen::UserExec(Option_t *){
     AliInfo(Form("Initializing TRD reco params for EventSpecie[%d]...",
       fESDev->GetEventSpecie()));
     fgReconstructor = new AliTRDReconstructor();
-    obj = ocdb->Get(AliCDBPath("TRD", "Calib", "RecoParam"));
-    obj->PrintMetaData();
-    TObjArray *recos((TObjArray*)obj->GetObject());
-    for(Int_t ireco(0); ireco<recos->GetEntriesFast(); ireco++){
-      AliTRDrecoParam *reco((AliTRDrecoParam*)recos->At(ireco));
-      Int_t es(reco->GetEventSpecie());
-      if(!(es&fESDev->GetEventSpecie())) continue;
-      fgReconstructor->SetRecoParam(reco);
-      TString s;
-      if(es&AliRecoParam::kLowMult) s="LowMult";
-      else if(es&AliRecoParam::kHighMult) s="HighMult";
-      else if(es&AliRecoParam::kCosmic) s="Cosmic";
-      else if(es&AliRecoParam::kCalib) s="Calib";
-      else s="Unknown";
-      AliInfo(Form("Using reco params for %s", s.Data()));
-      break;
+    if(!(obj = ocdb->Get(AliCDBPath("TRD", "Calib", "RecoParam")))){
+      AliError("RECO PARAM failed initialization.");
+      fgReconstructor->SetRecoParam(AliTRDrecoParam::GetLowFluxParam());
+    } else {
+      obj->PrintMetaData();
+      TObjArray *recos((TObjArray*)obj->GetObject());
+      for(Int_t ireco(0); ireco<recos->GetEntriesFast(); ireco++){
+        AliTRDrecoParam *reco((AliTRDrecoParam*)recos->At(ireco));
+        Int_t es(reco->GetEventSpecie());
+        if(!(es&fESDev->GetEventSpecie())) continue;
+        fgReconstructor->SetRecoParam(reco);
+        TString s;
+        if(es&AliRecoParam::kLowMult) s="LowMult";
+        else if(es&AliRecoParam::kHighMult) s="HighMult";
+        else if(es&AliRecoParam::kCosmic) s="Cosmic";
+        else if(es&AliRecoParam::kCalib) s="Calib";
+        else s="Unknown";
+        AliInfo(Form("Using reco params for %s", s.Data()));
+        break;
+      }
     }
     SetInitOCDB();
   }

diff --git a/PWG1/TRD/AliTRDpidRefMaker.cxx b/PWG1/TRD/AliTRDpidRefMaker.cxx
index f580102fe121211c3fe683909473ad2037857e2d..941196a9d681ff49f42af64d90af7a974b7b7929 100644 (file)
--- a/PWG1/TRD/AliTRDpidRefMaker.cxx
+++ b/PWG1/TRD/AliTRDpidRefMaker.cxx
@@ -148,13 +148,13 @@ void AliTRDpidRefMaker::UserExec(Option_t *)
 
   AliDebug(1, Form("Entries: Ev[%d] Tracks[%d] V0[%d] PID[%d]", ev, fTracks->GetEntriesFast(), fV0s->GetEntriesFast(), fInfo->GetEntriesFast()));
   AliTRDtrackInfo     *track = NULL;
-  AliTRDtrackV1    *trackTRD = NULL;
+  //AliTRDtrackV1    *trackTRD = NULL;
   AliTrackReference     *ref = NULL;
   const AliTRDtrackInfo::AliESDinfo *infoESD = NULL;
   for(Int_t itrk=0; itrk<fTracks->GetEntriesFast(); itrk++){
     track = (AliTRDtrackInfo*)fTracks->UncheckedAt(itrk);
     if(!track->HasESDtrack()) continue;
-    trackTRD = track->GetTrack();
+    //trackTRD = track->GetTrack();
     infoESD  = track->GetESDinfo();
     Double32_t *infoPID = infoESD->GetSliceIter();
     Int_t n = infoESD->GetNSlices() - AliTRDgeometry::kNlayer;
@@ -171,7 +171,7 @@ void AliTRDpidRefMaker::UserExec(Option_t *)
     // fill the pid information
     SetRefPID(fRefPID, track, infoESD, fPID);
     // get particle type
-    Int_t idx(TMath::LocMax(AliPID::kSPECIES, fPID)); 
+    Int_t idx(TMath::Max(Long64_t(0), TMath::LocMax(AliPID::kSPECIES, fPID))); 
     if(fPID[idx]<1.e-5) continue;
     
     // prepare PID data array

diff --git a/PWG1/TRD/AliTRDpidRefMakerLQ.cxx b/PWG1/TRD/AliTRDpidRefMakerLQ.cxx
index 77fbda72962cd08283300ff73b07dd6fa4e931f1..62afb1ac0b8856865de95a24fa708caa8fa0ee90 100644 (file)
--- a/PWG1/TRD/AliTRDpidRefMakerLQ.cxx
+++ b/PWG1/TRD/AliTRDpidRefMakerLQ.cxx
@@ -318,7 +318,7 @@ Bool_t AliTRDpidRefMakerLQ::PostProcess()
       // estimate bucket statistics
       Int_t idx(AliTRDCalPIDLQ::GetModelID(ip,is)),
             nb(kMinBuckets), // number of buckets
-       ns((Int_t)(((Float_t)(ndata[idx]))/nb));    //statistics/bucket
+            ns((Int_t)(((Float_t)(ndata[idx]))/nb));    //statistics/bucket
             
       AliDebug(2, Form("pBin[%d] sBin[%d] n[%d] ns[%d] nb[%d]", ip, is, ndata[idx], ns, nb));
       if(ns<Int_t(kMinStat)){
@@ -418,7 +418,10 @@ Bool_t AliTRDpidRefMakerLQ::PostProcess()
         }
       }
 
-      pdf=dynamic_cast<TKDPDF*>(fPDF->At(idx));
+      if(!(pdf=dynamic_cast<TKDPDF*>(fPDF->At(idx)))){
+        AliWarning(Form("Missing pdf for model id[%d]", idx));
+        continue;
+      }
       TH1 *h1 = (TH1D*)((TObjArray*)fContainer->At(ip))->At(is);
       ax = h1->GetXaxis();
       h1->Clear();

diff --git a/PWG1/TRD/AliTRDpidRefMakerNN.cxx b/PWG1/TRD/AliTRDpidRefMakerNN.cxx
index 5128d6f2a982ab282a00b592802d5a5ce8f28f37..987644eaf9c122a95ff27ed5d00f8954a217c7f7 100644 (file)
--- a/PWG1/TRD/AliTRDpidRefMakerNN.cxx
+++ b/PWG1/TRD/AliTRDpidRefMakerNN.cxx
@@ -205,10 +205,10 @@ Bool_t AliTRDpidRefMakerNN::PostProcess()
   else{
     for(Int_t iMomBin = 0; iMomBin < AliTRDCalPID::kNMom; iMomBin++){
       if(fTrain[iMomBin] -> GetN() < fMinTrain){
-       AliError(Form("Warning in AliTRDpidRefMakerNN::PostProcess : Not enough events for training available for momentum bin [%d]! Please check Data sample!", iMomBin));
-       continue;
+        AliError(Form("Warning in AliTRDpidRefMakerNN::PostProcess : Not enough events for training available for momentum bin [%d]! Please check Data sample!", iMomBin));
+        continue;
       }
-      MakeRefs(fTrainMomBin);
+      MakeRefs(iMomBin);
       MonitorTraining(iMomBin);
     }
   }

diff --git a/PWG1/TRD/AliTRDpwg1Helper.cxx b/PWG1/TRD/AliTRDpwg1Helper.cxx
index b8656dc94afdd2c7c164bf30c15905dd163ad873..9cd74a4f5288f15d8b929cd5cbb993ded2491fe2 100644 (file)
--- a/PWG1/TRD/AliTRDpwg1Helper.cxx
+++ b/PWG1/TRD/AliTRDpwg1Helper.cxx
@@ -126,8 +126,8 @@ void AliTRDpwg1Helper::MergeProd(const Char_t *mark, const Char_t *files, const
 // Recursively merge files named "mark" from list in "files" in groups of "nBatch" files.
 // parameter "level" is used to index recurent calls of this function.
 
-  Char_t lMERGE[8]; sprintf(lMERGE, "%04d.lst", (Int_t)gRandom->Uniform(9999.));
-  Char_t lPURGE[8]; sprintf(lPURGE, "%04d.lst", (Int_t)gRandom->Uniform(9999.));
+  Char_t lMERGE[8]; snprintf(lMERGE, 8, "%04d.lst", (Int_t)gRandom->Uniform(9999.));
+  Char_t lPURGE[8]; snprintf(lPURGE, 8, "%04d.lst", (Int_t)gRandom->Uniform(9999.));
 
   // purge file list
   std::string filename;
@@ -188,8 +188,7 @@ const Char_t* AliTRDpwg1Helper::MergeBatch(const Char_t *mark, const Char_t *fil
       continue;
     }
     if(kSVN){ // download SVN info for trending
-      std::string base=filename.substr(0, filename.find_last_of('/'));
-      if(gSystem->Exec(Form("if [ ! -f svnInfo.log ]; then cp -v %s/svnInfo.log %s; fi", base.c_str(), gSystem->ExpandPathName("$PWD"))) == 0) kSVN=kFALSE;
+      if(gSystem->Exec(Form("if [ ! -f svnInfo.log ]; then cp -v %s/svnInfo.log %s; fi", Basename(filename.c_str()), gSystem->ExpandPathName("$PWD"))) == 0) kSVN=kFALSE;
     }
     Info("MergeBatch()", filename.c_str());
     if(!fFM.AddFile(filename.c_str())) return NULL;

diff --git a/PWG1/TRD/AliTRDrecoTask.cxx b/PWG1/TRD/AliTRDrecoTask.cxx
index f8fe77bdb052a9dda56271545c533f17b068fe8e..fcf3794ba4f2a6c9ae9a0a2cf6239c6d63e1248b 100644 (file)
--- a/PWG1/TRD/AliTRDrecoTask.cxx
+++ b/PWG1/TRD/AliTRDrecoTask.cxx
@@ -47,7 +47,8 @@ AliTRDrecoTask::AliTRDrecoTask()
   ,fkESD(NULL)
   ,fPlotFuncList(NULL)
 {
-// Default constructor  
+// Default constructor
+  snprintf(fNameId, 10, "no name");
 }
 
 //_______________________________________________________
@@ -64,6 +65,7 @@ AliTRDrecoTask::AliTRDrecoTask(const char *name, const char *title)
 // Constructor for all derived performance tasks
 
   SetTitle(title);
+  snprintf(fNameId, 10, "no name");
   DefineInput (1, TObjArray::Class()); // track list
   DefineOutput(1, TObjArray::Class()); // histogram list
 }

diff --git a/PWG1/TRD/AliTRDrecoTask.h b/PWG1/TRD/AliTRDrecoTask.h
index f14a8859997eefb2f2b8b9dec66dd239c247b4c5..53564cd972a35c114107344d28c415dc2c41212c 100644 (file)
--- a/PWG1/TRD/AliTRDrecoTask.h
+++ b/PWG1/TRD/AliTRDrecoTask.h
@@ -60,7 +60,7 @@ public:
   virtual Bool_t PutTrendValue(const Char_t *name, Double_t val);
   virtual void   SetFriends(Bool_t fr = kTRUE) {SetBit(kFriends, fr);}
   virtual void   SetMCdata(Bool_t mc = kTRUE) {SetBit(kMCdata, mc);}
-  virtual void   SetNameId(const Char_t *nid) {sprintf(fNameId, "%s", nid);}
+  virtual void   SetNameId(const Char_t *nid) {snprintf(fNameId, 10, "%s", nid);}
   virtual void   SetPostProcess(Bool_t pp = kTRUE) {SetBit(kPostProcess, pp);}
   virtual void   Terminate(Option_t *);
 

diff --git a/PWG1/TRD/AliTRDresolution.cxx b/PWG1/TRD/AliTRDresolution.cxx
index 1acf84036d5abd0f516b872fbe3f4258428fb275..b10ef819b4c235f43194aa390cb9fd9dce554864 100644 (file)
--- a/PWG1/TRD/AliTRDresolution.cxx
+++ b/PWG1/TRD/AliTRDresolution.cxx
@@ -1858,7 +1858,7 @@ void AliTRDresolution::MakeSummary()
   p=cOut->cd(3); 
   p->SetRightMargin(0.06);p->SetTopMargin(0.06);
   xy[0]=-.5; xy[1]=-0.5; xy[2]=fgkNresYsegm[fSegmentLevel]-.5; xy[3]=2.5;
-  GetGraphArray(xy, kCluster, 1, 1);
+  if(!GetGraphArray(xy, kCluster, 1, 1)) return;
 
   p=cOut->cd(4); 
   p->SetRightMargin(0.16);p->SetTopMargin(0.06);
@@ -1883,7 +1883,7 @@ void AliTRDresolution::MakeSummary()
   p=cOut->cd(6); 
   p->SetRightMargin(0.06);p->SetTopMargin(0.06);
   xy[0]=-.5; xy[1]=-0.5; xy[2]=fgkNresYsegm[fSegmentLevel]-.5; xy[3]=2.5;
-  GetGraphArray(xy, kTrack, 1, 1);
+  if(!GetGraphArray(xy, kTrack, 1, 1)) return;
 
   cOut->SaveAs(Form("%s.gif", cOut->GetName()));
 
@@ -2278,7 +2278,7 @@ TObjArray* AliTRDresolution::BuildMonitorContainerCluster(const char* name, Bool
   TH1 *h(NULL); char hname[100], htitle[300];
 
   // tracklet resolution/pull in y direction
-  sprintf(hname, "%s_%s_Y", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_Y", GetNameId(), name);
   sprintf(htitle, "Y res for \"%s\" @ %s;tg(#phi);#Delta y [cm];%s", GetNameId(), name, fgkResYsegmName[fSegmentLevel]);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     Int_t nybins=fgkNresYsegm[fSegmentLevel];
@@ -2289,8 +2289,8 @@ TObjArray* AliTRDresolution::BuildMonitorContainerCluster(const char* name, Bool
                  nybins, -0.5, nybins-0.5);// segment
   } else h->Reset();
   arr->AddAt(h, 0);
-  sprintf(hname, "%s_%s_YZpull", GetNameId(), name);
-  sprintf(htitle, "YZ pull for \"%s\" @ %s;%s;#Delta y  / #sigma_{y};#Delta z  / #sigma_{z}", GetNameId(), name, fgkResYsegmName[fSegmentLevel]);
+  snprintf(hname, 100, "%s_%s_YZpull", GetNameId(), name);
+  snprintf(htitle, 300, "YZ pull for \"%s\" @ %s;%s;#Delta y  / #sigma_{y};#Delta z  / #sigma_{z}", GetNameId(), name, fgkResYsegmName[fSegmentLevel]);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     h = new TH3S(hname, htitle, fgkNresYsegm[fSegmentLevel], -0.5, fgkNresYsegm[fSegmentLevel]-0.5, 100, -4.5, 4.5, 100, -4.5, 4.5);
   } else h->Reset();
@@ -2311,14 +2311,14 @@ TObjArray* AliTRDresolution::BuildMonitorContainerTracklet(const char* name, Boo
   TH1 *h(NULL); char hname[100], htitle[300];
 
   // tracklet resolution/pull in z direction
-  sprintf(hname, "%s_%s_Z", GetNameId(), name);
-  sprintf(htitle, "Z res for \"%s\" @ %s;tg(#theta);#Delta z [cm];row cross", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_Z", GetNameId(), name);
+  snprintf(htitle, 300, "Z res for \"%s\" @ %s;tg(#theta);#Delta z [cm];row cross", GetNameId(), name);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     h = new TH3S(hname, htitle, 50, -1., 1., 100, -1.5, 1.5, 2, -0.5, 1.5);
   } else h->Reset();
   arr->AddAt(h, 2);
-  sprintf(hname, "%s_%s_Zpull", GetNameId(), name);
-  sprintf(htitle, "Z pull for \"%s\" @ %s;tg(#theta);#Delta z  / #sigma_{z};row cross", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_Zpull", GetNameId(), name);
+  snprintf(htitle, 300, "Z pull for \"%s\" @ %s;tg(#theta);#Delta z  / #sigma_{z};row cross", GetNameId(), name);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     h = new TH3S(hname, htitle, 50, -1., 1., 100, -5.5, 5.5, 2, -0.5, 1.5);
     h->GetZaxis()->SetBinLabel(1, "no RC");
@@ -2327,8 +2327,8 @@ TObjArray* AliTRDresolution::BuildMonitorContainerTracklet(const char* name, Boo
   arr->AddAt(h, 3);
 
   // tracklet to track phi resolution
-  sprintf(hname, "%s_%s_PHI", GetNameId(), name);
-  sprintf(htitle, "#Phi res for \"%s\" @ %s;tg(#phi);#Delta #phi [rad];entries", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_PHI", GetNameId(), name);
+  snprintf(htitle, 300, "#Phi res for \"%s\" @ %s;tg(#phi);#Delta #phi [rad];entries", GetNameId(), name);
   if(!(h = (TH2I*)gROOT->FindObject(hname))){
     h = new TH2I(hname, htitle, 21, -.33, .33, 100, -.5, .5);
   } else h->Reset();
@@ -2353,23 +2353,23 @@ TObjArray* AliTRDresolution::BuildMonitorContainerTrack(const char* name)
   TAxis *ax(NULL);
 
   // snp pulls
-  sprintf(hname, "%s_%s_SNPpull", GetNameId(), name);
-  sprintf(htitle, "SNP pull for \"%s\" @ %s;tg(#phi);#Delta snp  / #sigma_{snp};entries", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_SNPpull", GetNameId(), name);
+  snprintf(htitle, 300, "SNP pull for \"%s\" @ %s;tg(#phi);#Delta snp  / #sigma_{snp};entries", GetNameId(), name);
   if(!(h = (TH2I*)gROOT->FindObject(hname))){
     h = new TH2I(hname, htitle, 60, -.3, .3, 100, -4.5, 4.5);
   } else h->Reset();
   arr->AddAt(h, 5);
 
   // theta resolution
-  sprintf(hname, "%s_%s_THT", GetNameId(), name);
-  sprintf(htitle, "#Theta res for \"%s\" @ %s;tg(#theta);#Delta #theta [rad];entries", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_THT", GetNameId(), name);
+  snprintf(htitle, 300, "#Theta res for \"%s\" @ %s;tg(#theta);#Delta #theta [rad];entries", GetNameId(), name);
   if(!(h = (TH2I*)gROOT->FindObject(hname))){
     h = new TH2I(hname, htitle, 100, -1., 1., 100, -5e-3, 5e-3);
   } else h->Reset();
   arr->AddAt(h, 6);
   // tgl pulls
-  sprintf(hname, "%s_%s_TGLpull", GetNameId(), name);
-  sprintf(htitle, "TGL pull for \"%s\" @ %s;tg(#theta);#Delta tgl  / #sigma_{tgl};entries", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_TGLpull", GetNameId(), name);
+  snprintf(htitle, 300, "TGL pull for \"%s\" @ %s;tg(#theta);#Delta tgl  / #sigma_{tgl};entries", GetNameId(), name);
   if(!(h = (TH2I*)gROOT->FindObject(hname))){
     h = new TH2I(hname, htitle, 100, -1., 1., 100, -4.5, 4.5);
   } else h->Reset();
@@ -2385,8 +2385,8 @@ TObjArray* AliTRDresolution::BuildMonitorContainerTrack(const char* name)
   for(Int_t i=0; i<kNdpt+1; i++,lDPt+=2.e-3) binsDPt[i]=lDPt;
 
   // Pt resolution
-  sprintf(hname, "%s_%s_Pt", GetNameId(), name);
-  sprintf(htitle, "P_{t} res for \"%s\" @ %s;p_{t} [GeV/c];#Delta p_{t}/p_{t}^{MC};SPECIES", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_Pt", GetNameId(), name);
+  snprintf(htitle, 300, "#splitline{P_{t} res for}{\"%s\" @ %s};p_{t} [GeV/c];#Delta p_{t}/p_{t}^{MC};SPECIES", GetNameId(), name);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     h = new TH3S(hname, htitle, 
                  kNpt, binsPt, kNdpt, binsDPt, kNspc, binsSpc);
@@ -2395,8 +2395,8 @@ TObjArray* AliTRDresolution::BuildMonitorContainerTrack(const char* name)
   } else h->Reset();
   arr->AddAt(h, 8);
   // 1/Pt pulls
-  sprintf(hname, "%s_%s_1Pt", GetNameId(), name);
-  sprintf(htitle, "1/P_{t} pull for \"%s\" @ %s;1/p_{t}^{MC} [c/GeV];#Delta(1/p_{t})/#sigma(1/p_{t});SPECIES", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_1Pt", GetNameId(), name);
+  snprintf(htitle, 300, "#splitline{1/P_{t} pull for}{\"%s\" @ %s};1/p_{t}^{MC} [c/GeV];#Delta(1/p_{t})/#sigma(1/p_{t});SPECIES", GetNameId(), name);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     h = new TH3S(hname, htitle, 
                  kNpt, 0., 2., 100, -4., 4., kNspc, -5.5, 5.5);
@@ -2405,8 +2405,8 @@ TObjArray* AliTRDresolution::BuildMonitorContainerTrack(const char* name)
   } else h->Reset();
   arr->AddAt(h, 9);
   // P resolution
-  sprintf(hname, "%s_%s_P", GetNameId(), name);
-  sprintf(htitle, "P res for \"%s\" @ %s;p [GeV/c];#Delta p/p^{MC};SPECIES", GetNameId(), name);
+  snprintf(hname, 100, "%s_%s_P", GetNameId(), name);
+  snprintf(htitle, 300, "P res for \"%s\" @ %s;p [GeV/c];#Delta p/p^{MC};SPECIES", GetNameId(), name);
   if(!(h = (TH3S*)gROOT->FindObject(hname))){
     h = new TH3S(hname, htitle, 
                  kNpt, binsPt, kNdpt, binsDPt, kNspc, binsSpc);
@@ -2591,7 +2591,7 @@ Bool_t AliTRDresolution::Process(TH2 * const h2, TF1 *f, Float_t k, TGraphErrors
   // Do the processing
   //
 
-  Char_t pn[10]; sprintf(pn, "p%03d", fIdxPlot);
+  Char_t pn[10]; snprintf(pn, 10, "p%03d", fIdxPlot);
   Int_t n = 0;
   if((n=g[0]->GetN())) for(;n--;) g[0]->RemovePoint(n);
   if((n=g[1]->GetN())) for(;n--;) g[1]->RemovePoint(n);
@@ -2766,7 +2766,7 @@ Bool_t AliTRDresolution::Process3DL(ETRDresolutionPlot plot, Int_t idx, TF1 *f,
   if(!(gm = (TGraphAsymmErrors*)((TObjArray*)fGraphM->At(plot))->At(0))) return kFALSE;
   if(!(gs = (TGraphErrors*)((TObjArray*)fGraphS->At(plot)))) return kFALSE;
 
-  Float_t x, r, mpv, xM, xm;
+  Float_t x(0.), r(0.), mpv(0.), xM(0.), xm(0.);
   TAxis *ay = h3->GetYaxis();
   for(Int_t iy=1; iy<=h3->GetNbinsY(); iy++){
     ay->SetRange(iy, iy);

diff --git a/PWG1/TRD/info/AliTRDtrendValue.cxx b/PWG1/TRD/info/AliTRDtrendValue.cxx
index 72954f1168e60506dd2f5590c057ce9a56b2b694..e4c03146a2bc722841037b7909581e2c4e83fad4 100644 (file)
--- a/PWG1/TRD/info/AliTRDtrendValue.cxx
+++ b/PWG1/TRD/info/AliTRDtrendValue.cxx
@@ -27,7 +27,7 @@ AliTRDtrendValue::AliTRDtrendValue()
 {
 //  Constructor. Reset all fields.
   memset(fLimits, 0, 2*(kNlevels+1)*sizeof(Double_t));
-  for(Int_t ilevel(kNlevels); ilevel--; ) sprintf(fAlarmMessage[ilevel], " ");
+  for(Int_t ilevel(kNlevels); ilevel--; ) snprintf(fAlarmMessage[ilevel], 1024, " ");
 }
 
 //____________________________________________
@@ -46,7 +46,7 @@ AliTRDtrendValue::AliTRDtrendValue(Char_t *n, Char_t *t)
   } else SetName(n);
 
   memset(fLimits, 0, 2*(kNlevels+1)*sizeof(Double_t));
-  for(Int_t ilevel(kNlevels); ilevel--; ) sprintf(fAlarmMessage[ilevel], " ");
+  for(Int_t ilevel(kNlevels); ilevel--; ) snprintf(fAlarmMessage[ilevel], 1024, " ");
 }
 
 //____________________________________________
@@ -103,8 +103,8 @@ const char* AliTRDtrendValue::GetValueName() const
 const char* AliTRDtrendValue::GetResponsible(Char_t *n, Char_t *mail) const
 {
 // Get responsible with name and mail
-  if(n) sprintf(n, "%s", fResponsible.fNameR);
-  if(mail) sprintf(mail, "%s", fResponsible.fMail);
+  if(n) snprintf(n, 100, "%s", fResponsible.fNameR);
+  if(mail) snprintf(mail, 200, "%s", fResponsible.fMail);
   return Form("%s <%s>", fResponsible.fNameR, fResponsible.fMail);
 }
 
@@ -113,8 +113,8 @@ const char* AliTRDtrendValue::GetNotifiable(Int_t in, Char_t *n, Char_t *mail) c
 {
 // Get noticible person "in" with name and mail
   if(in<0||in>=fNnotifiable) return NULL;
-  if(n) sprintf(n, "%s", fNotifiable[in].fNameR);
-  if(mail) sprintf(mail, "%s", fNotifiable[in].fMail);
+  if(n) snprintf(n, 100, "%s", fNotifiable[in].fNameR);
+  if(mail) snprintf(mail, 200, "%s", fNotifiable[in].fMail);
   return Form("%s <%s>", fNotifiable[in].fNameR, fNotifiable[in].fMail);
 }
 
@@ -126,8 +126,8 @@ void AliTRDtrendValue::SetNotifiable(const Char_t *name, const Char_t *mail)
     AliWarning(Form("Could not add %s for notification. Only %d persons can be registered for notification.", name, kNnotifiable));
     return;
   }
-  sprintf(fNotifiable[fNnotifiable].fNameR, "%s", name);
-  sprintf(fNotifiable[fNnotifiable].fMail, "%s", mail);
+  snprintf(fNotifiable[fNnotifiable].fNameR, 100, "%s", name);
+  snprintf(fNotifiable[fNnotifiable].fMail, 200, "%s", mail);
   fNnotifiable++;
 }
 
@@ -135,8 +135,8 @@ void AliTRDtrendValue::SetNotifiable(const Char_t *name, const Char_t *mail)
 void AliTRDtrendValue::SetResponsible(const Char_t *name, const Char_t *mail) 
 {
 // set responsible person for trend
-  sprintf(fResponsible.fNameR, "%s", name);
-  sprintf(fResponsible.fMail, "%s", mail);
+  snprintf(fResponsible.fNameR, 100, "%s", name);
+  snprintf(fResponsible.fMail, 200, "%s", mail);
 }
 
 //____________________________________________
@@ -165,6 +165,6 @@ void AliTRDtrendValue::Print(Option_t */*o*/) const
 AliTRDtrendValue::AliTRDtrendValueResponsible::AliTRDtrendValueResponsible(Char_t *n, Char_t *m) 
 {
 // define person with mail and mail
-  if(n) sprintf(fNameR, "%s", n); else sprintf(fNameR, " ");
-  if(m) sprintf(fMail, "%s", m); else sprintf(fMail, " ");
+  if(n) snprintf(fNameR, 100, "%s", n); else snprintf(fNameR, 100, " ");
+  if(m) snprintf(fMail, 200, "%s", m); else snprintf(fMail, 200, " ");
 }

diff --git a/PWG1/TRD/info/AliTRDtrendingManager.cxx b/PWG1/TRD/info/AliTRDtrendingManager.cxx
index 8345cb096304fd9b55fb3a06b2a18df03f2c124f..dd50e4c9a94511a3dc29f9b61be9c9e5d6134ed7 100644 (file)
--- a/PWG1/TRD/info/AliTRDtrendingManager.cxx
+++ b/PWG1/TRD/info/AliTRDtrendingManager.cxx
@@ -37,10 +37,10 @@ AliTRDtrendingManager* AliTRDtrendingManager::Instance()
     if(!trd){ 
       AliWarningGeneral("AliTRDtrendingManager", "TRD OCDB manager not initialized. No trending DB available.");
     } else {
-      const TObjArray *trendMap(NULL/*trd->GetTrendMap()*/);
+/*      const TObjArray *trendMap(trd->GetTrendMap());
       if(!trendMap){
         AliWarningGeneral("AliTRDtrendingManager", "No TRD trending DB available  for TRD.");
-      } else fgInstance->fEntries=(TObjArray*)trendMap->Clone();
+      } else fgInstance->fEntries=(TObjArray*)trendMap->Clone();*/
     }
   }
 

diff --git a/PWG1/TRD/info/AliTRDv0Info.cxx b/PWG1/TRD/info/AliTRDv0Info.cxx
index 3c116c35ac6d09681f3525f791447557b7f2a06c..7b1b311cd6b76ef6a22cc8f556e58953cc6e7aa0 100644 (file)
--- a/PWG1/TRD/info/AliTRDv0Info.cxx
+++ b/PWG1/TRD/info/AliTRDv0Info.cxx
@@ -78,7 +78,8 @@ AliTRDv0Info::AliTRDv0Info()
   memset(fArmenteros, 0, kNDecays*sizeof(Bool_t));
   memset(fTPCdEdx, 0, kNDaughters*sizeof(Float_t));
   memset(fChi2ndf, 0, kNDecays*sizeof(Double_t));
-
+  memset(fDownOpenAngle, 0, kNDecays*sizeof(Float_t));
+  memset(fDownPsiPair, 0, kNDecays*sizeof(Float_t));
   /////////////////////////////////////////////////////////////////////////////
   //Set Cut values: First specify decay in brackets, then the actual cut value!
   /////////////////////////////////////////////////////////////////////////////